ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran" <stev...@iseran.com>
Subject Re: [PATCH] Buid file parse error msgs wrong when including XML s nippets
Date Wed, 03 Jul 2002 16:36:10 GMT

----- Original Message -----
From: "Jason Brittain" <jasonb@collab.net>
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Sent: Wednesday, July 03, 2002 09:21
Subject: Re: [PATCH] Buid file parse error msgs wrong when including XML s
nippets


>
> Yes, I saw that wonderful modification to support <import>, which is
> exactly what we needed, but since it's not going to be in Ant 1.5
> we're (so far) going to just use included XML snippets.  I'm looking
> forward to seeing and trying Antipede!  :)
>
> But, for the time being, and for Ant 1.5, I'd just like Ant to
> correctly report which file needs fixing when something went wrong.

I agree, it would be nice, but Magesh is in charge of what goes in or out.
So while I am +1 of this in ant 1.6, I am neutral to this going in to
ant1.5, there being so little time to test it.

> It's a very small change (a single line of code)

you should know that is one of the danger signs of a gug ' "It was such a
little change I didnt think it would have any effect".

Test cases to go with the change are mandatory here. New ones to show that
the reporting works, and validation that the inclusion still works.



>
> --
> Jason Brittain
> <jasonb (~at~) collab (~dot~) net>
> CollabNet http://www.collab.net
>
> Dominique Devienne wrote:
> > You might want to look at
> > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10276 which adds the
> > <import> top-level element with special handling in
ProjectHelperImpl.java.
> > Your patch may (or not) need to address what the patch there does for
proper
> > error reporting too. Thanks, --DD
> >
> > -----Original Message-----
> > From: Jason Brittain [mailto:jasonb@collab.net]
> > Sent: Tuesday, July 02, 2002 8:14 PM
> > To: ant-dev@jakarta.apache.org
> > Subject: [PATCH] Buid file parse error msgs wrong when including XML
> > snippets
> >
> >
> > Hi there.
> >
> > Currently, whenever you include an XML snippet in a project file like
> > the FAQ shows here:
> >
> > http://jakarta.apache.org/ant/faq.html#xml-entity-include
> >
> > It works fine, but if there's a parser error in the file I'm including,
> > Ant incorrectly tells me that the error is in the file I included it in
> > (instead of in the included file).  I believe this is a bug.
> >
> > The attached patch of ProjectHelperImpl.java (CVS head's version) seems
> > to fix this problem for parse errors.  I've also attached a patch for
> > Ant 1.4.
> >
> > Can/should this be fixed by Ant 1.5 (final)?
> >
> > There are also other spots where this same bug probably occurs after
> > Project parse time, which I'm going to investigate next..
> >
> > Cheers.
> >
>
>
>
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message