Return-Path: 
 <ant-dev-return-34112-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 44650 invoked from network); 19 Jun 2002 14:52:01 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 19 Jun 2002 14:52:01 -0000
Received: (qmail 26145 invoked by uid 97); 19 Jun 2002 14:52:05 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 26123 invoked by uid 97); 19 Jun 2002 14:52:04 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 26107 invoked by uid 50); 19 Jun 2002 14:52:03 -0000
Date: 19 Jun 2002 14:52:03 -0000
Message-ID: <20020619145203.26106.qmail@nagoya.betaversion.org>
From: bugzilla@apache.org
To: ant-dev@jakarta.apache.org
Cc: 
Subject: DO NOT REPLY [Bug 9973]  -
    Answer for groelen
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9973>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9973

Answer for groelen





------- Additional Comments From Geroen.dierckx@eds.com  2002-06-19 14:52 -------
"The Environment Variable is global to the shell in which it is invoked 
The developer does not need to recompile the code since the Environment 
Variable is outside the code.."

What is this about recompiling the code? What code? If you pass the home 
directory as an attribute to the WebSphere element you also don't have to 
recompile the code.

I just thought it might be more logical to set the home directory as an 
attribute of the websphere element. Since that is the normal way of passing 
values to an element instead of using properties.

Instead of this:
...
<property name="websphere.home" value="c:${file.separator}
WebSphere${file.separator}AppServer"/>
...
<target name="buildEJBWebSphere">
    ...
    <websphere keepgeneric="true" dbvendor="${server.ejb.dbvendor}" 
ejbdeploy="true" oldCMP="false" tempdir="${computer.temp}" 
destdir="${server.deploy.ejb}" suffix="${server.deploy.ejb.suffix}">
      <wasclasspath refid="was.class.path" />
      <classpath refid="project.class.path" />
    </websphere>
    ...
</target>
...

you would have something like this:
...
<target name="buildEJBWebSphere">
    ...
    <websphere washome="c:${file.separator}WebSphere${file.separator}AppServer" 
keepgeneric="true" dbvendor="${server.ejb.dbvendor}" ejbdeploy="true" 
oldCMP="false" tempdir="${computer.temp}" destdir="${server.deploy.ejb}" 
suffix="${server.deploy.ejb.suffix}">
      <wasclasspath refid="was.class.path" />
      <classpath refid="project.class.path" />
    </websphere>
    ...
</target>
...


Also, if the websphere home directory has to be set by using a property, it 
should at least be mentioned in the documentation. Because now the only way of 
knowing you have to set that property, is by looking in the source code of ANT.
(or I overlooked something)

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>