ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Oxspring" <roxspr...@imapmail.org>
Subject Re: DO NOT REPLY [Bug 3836] - Mail task should allow port specification
Date Mon, 17 Jun 2002 09:54:25 GMT
Thanks Stefan... I was obviously looking at an out of date copy when writing
my last message.  After seeing the correct uptodate sources (trusting
viewcvs.cgi rather than my commandline skills) I investigated the problem a
bit more and finally figured it out:

The distinction is that in the xml I was using (based on Joey Avis's example
in bugzilla) never sets a message at all.  Thus the setMessage /
setMessageFile methods are never fired and an empty message is created
(EmailTask.java:447) but not configured.

Anyway, patch attached.

Rob


----- Original Message -----
From: "Stefan Bodewig" <bodewig@apache.org>
To: <ant-dev@jakarta.apache.org>
Sent: Monday, June 17, 2002 7:21 AM
Subject: Re: DO NOT REPLY [Bug 3836] - Mail task should allow port
specification


> On Fri, 14 Jun 2002, Rob Oxspring <roxspring@imapmail.org> wrote:
>
> > I had checked out ANT_15_BRANCH
>
> should work (as long as you've updated it ;-).
>
> > and have since tried ANT_15_B1 and ANT_15_B2
>
> It has been bug #9574 which has been fixed after beta2.
>
> > I can't see how mailer is ever assigned a project unless
> > addMessage(Messsage) is called, which is a bit messed up when there
> > are the setMessage and setMessageFile alternatives.
>
> I patched the setter methods to do that explicitly (we are guaranteed
> that setProject has been called before the setters get invoked on the
> task).  The relevant patch is here:
>
>
<http://cvs.apache.org/viewcvs/jakarta-ant/src/main/org/apache/tools/ant/tas
kdefs/email/EmailTask.java.diff?r1=1.12&r2=1.12.2.1>
>
> Stefan
>
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
>
>
>

Mime
View raw message