Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 43826 invoked from network); 18 May 2002 04:46:15 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 18 May 2002 04:46:15 -0000 Received: (qmail 2016 invoked by uid 97); 18 May 2002 04:46:23 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 1978 invoked by uid 97); 18 May 2002 04:46:23 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 1966 invoked by uid 98); 18 May 2002 04:46:22 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Content-Type: text/plain; charset="iso-8859-1" From: Adam Murdoch To: "Ant Developers List" Subject: Re: cvs commit: jakarta-ant-myrmidon/container/src/java/org/apache/myrmidon/interfaces/model ModelElementSaxHandler.java ModelElementUtil.java Date: Sat, 18 May 2002 14:45:49 +1000 X-Mailer: KMail [version 1.4] References: <20020518040558.3567.qmail@icarus.apache.org> <200205181416.18185.peter@apache.org> In-Reply-To: <200205181416.18185.peter@apache.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: <200205181445.49174.adammurdoch@apache.org> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sat, 18 May 2002 14:16, Peter Donald wrote: > On Sat, 18 May 2002 14:05, adammurdoch@apache.org wrote: > > adammurdoch 02/05/17 21:05:58 > > > > Modified: container/src/java/org/apache/myrmidon/components/buil= der > > DefaultProjectBuilder.java > > Added: container/src/java/org/apache/myrmidon/interfaces/mode= l > > ModelElementSaxHandler.java ModelElementUtil.= java > > Removed: container/src/java/org/apache/myrmidon/components/buil= der > > ModelElementSaxHandler.java ModelElementUtil.= java > > Log: > > Move the ModelElement util stuff to interfaces, so that it's visibl= e > > outside the container classloader. > > I owuld rather have a ModelBuilder service/interface that happened to u= se > the ModelElement*.java and just expose the interface. I think this chan= ge > is probably exposing waaay too much outside of container :) Exposing too much? It's just a couple of utility classes: A SAX=20 ContentHandler that assembles a ModelElement, and a couple of static meth= ods. That's not to say there shouldn't be a ModelBuilder service, but even if = there=20 were it would not be appropriate for everything. We'd still need some ut= il=20 stuff somewhere. Maybe on ModelElement itself (the non-SAX stuff, at lea= st). =20 Whatever. Moving this stuff was just a quick fix. I don't particularly = care=20 where it ends up. --=20 Adam -- To unsubscribe, e-mail: For additional commands, e-mail: