Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 2873 invoked from network); 28 May 2002 23:14:26 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 28 May 2002 23:14:26 -0000 Received: (qmail 19336 invoked by uid 97); 28 May 2002 23:14:28 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 19303 invoked by uid 97); 28 May 2002 23:14:28 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 19291 invoked by uid 98); 28 May 2002 23:14:27 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Message-ID: <003d01c2069d$662ef220$6401a8c0@darden.virginia.edu> From: "Erik Hatcher" To: "Ant Developers List" References: <20020528222916.82787.qmail@web13405.mail.yahoo.com> Subject: Re: cvs commit: jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional PropertyFileTest.java Date: Tue, 28 May 2002 19:12:35 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2600.0000 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N I read the notes about the hesitation, but because no 'value' attribute was specified it stayed null because of this: private String value = null; See? So I don't understand the confusion about how it got to be null. Erik ----- Original Message ----- From: "Diane Holt" To: "Ant Developers List" Sent: Tuesday, May 28, 2002 6:29 PM Subject: Re: cvs commit: jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional PropertyFileTest.java > --- Erik Hatcher wrote: > > I didn't even look at the patch(es) posted... I just duplicated the bug > > and made the fix that was needed. > > If you read the bug report you closed with this change, you'll see that > the point of hesitation about putting through this particular change as > the fix is whether value (the variable) should ever really be null at that > point or whether there's a bug in the logic somewhere else along the line > and this approach to preventing the NPE just masks that. > > Diane > > ===== > (holtdl@yahoo.com) > > > > __________________________________________________ > Do You Yahoo!? > Yahoo! - Official partner of 2002 FIFA World Cup > http://fifaworldcup.yahoo.com > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: > > -- To unsubscribe, e-mail: For additional commands, e-mail: