ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cost...@covalent.net
Subject Re: [PATCH] Definer to allow types/tasks from the same jar to work
Date Fri, 24 May 2002 14:36:43 GMT
Thanks!

Based on the feedback I got so far from Peter and Conor,
I'll leave the default behavior unchanged ( i.e. different
class loaders ).

I'll also change the name of the attribute to 
'loaderId' - and make sure this would work with a
<loader> type.

Conor - I'm not sure we should add the <loader> type.
Let me know if you think it's required, it's quite 
easy to implement. 

Also for Conor - I really want to keep the magic property
for backward compatibility ( so a build.xml for 1.5 can 
be used with 1.4 ). After I commit the patch I'll update 
the docs for taskdef/typedef - if you want I can only include
the new attribute and leave the magic property undocumented.

Costin


On Fri, 24 May 2002, Magesh Umasankar wrote:

> ok, you have convinced me it is a bug :-)
> +1 to patch a fix.  wrt the actual patch that
> you have provided, I will leave it to others
> to make the call whether it can go in, in its
> current avatar.  I am +0 on it as I have not
> taken a close look at it yet and I realize
> it must get in in short order, if it is gonna
> make it to Beta 2.
> 
> Cheers,
> Magesh
> 
> ************************************************
> *  Criminal: A guy no different from the rest  *
> *  ...except that he got caught.               *
> ************************************************
> ----- Original Message ----- 
> From: <costinm@covalent.net>
> To: "Ant Developers List" <ant-dev@jakarta.apache.org>
> Sent: Friday, May 24, 2002 9:49 AM
> Subject: Re: [PATCH] Definer to allow types/tasks from the same jar to work
> 
> 
> > On Fri, 24 May 2002, Magesh Umasankar wrote:
> > 
> > > It is a nice-to-have, yes, but I don't see it as a bug
> > > in 1.5.  At least I would need some convincing to call
> > > it a bug ;-).  Depending upon that, it may or may not
> > > go into 1.5 branch.
> > 
> > Acording to ant 1.5 docs, you can define custom tasks and types
> > with <taskdef> and <typedef>. It is also a documented feature that
> > both taskdef and typedef can use a user-defined classpath to
> > load the implementation classes. 
> > 
> > If a user-defined task uses a user-defined type you get a 
> > ClassCastException. 
> > 
> > To me that means that <taskdef>/<typedef> with user-defined
> > classpath is broken. 
> > 
> > Please take a look at jakarta-tomcat-connectors/jk/native2/build.xml
> > and apache2-cpptasks target as an example. It won't work with ant1.5
> > without the patch.
> > 
> > Costin
> > 
> > 
> > 
> > --
> > To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
> > 
> 
> 
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
> 
> 


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message