ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ken.H...@ubsw.com
Subject RE: [PATCH/CONTRIB] JRun JSPC
Date Tue, 07 May 2002 12:28:17 GMT
So, do you think you'll merge any of the code prior to me working on it again. Or should I
grab the latest CVS and start reworking some of it? 
For the RegEx dependency, should this be spun off into a separate class (possibly with a reflective
call), or keep it local and use reflection to actually call the regex stuff?

I haven't really looked at the latest CVS yet, so will probs look at it in the next few days.

-----Original Message-----
From: Steve Loughran [mailto:steve_l@iseran.com]
Sent: 05 May 2002 03:47
To: Ant Developers List
Subject: Re: [PATCH/CONTRIB] JRun JSPC 



----- Original Message -----
From: "Ken Horn" <kenhorn1@yahoo.com>
To: <ant-dev@jakarta.apache.org>
Sent: Friday, May 03, 2002 10:26
Subject: [PATCH/CONTRIB] JRun JSPC


>
> This is a JSPC adapter to use JRun.
>
> It's based on the code from early December. Diffs are included (though
> admittedly without CVS version numbers..).


ok...that code went through quite the rework in late feb, I will see about
reconciliation

> I changed a couple of things in JspC.java, partyl to support filename
mapping -
> JSP to Java,

---since feb each jsp compiler can provide its own implementation of a
filename mapper, we are using the (slightly broken) jasper one by default

>and also to do <%@include .. %> staleness checks (which created a
> dependency on Apache RegEx).

That is nice . It'd be nice to not hard code that requirement in (i.e. with
reflection), but as we are still in the beta state, it may be possible to
get away with adding a new requirement

>
> I haven't had time to keep up with the cvs changes / do the 3.1 change, so
> thought I might as well submit for now..
>
thanks.

I fear that the release police will say 'bug fixes only' at this point in
the game, but I'd be tempted to merge in at least the changes to jspc's
basic classes, so that your stuff drops right in, and the <% include %>
checks go in there too.

Regardless, you do need to bring it up to date wrt. the CVS stuff before I
can work with it, because without jrun myself I'd never know if I was
getting things right

-steve


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Visit our website at http://www.ubswarburg.com

This message contains confidential information and is intended only 
for the individual named.  If you are not the named addressee you 
should not disseminate, distribute or copy this e-mail.  Please 
notify the sender immediately by e-mail if you have received this 
e-mail by mistake and delete this e-mail from your system.

E-mail transmission cannot be guaranteed to be secure or error-free 
as information could be intercepted, corrupted, lost, destroyed, 
arrive late or incomplete, or contain viruses.  The sender therefore 
does not accept liability for any errors or omissions in the contents 
of this message which arise as a result of e-mail transmission.  If 
verification is required please request a hard-copy version.  This 
message is provided for informational purposes and should not be 
construed as a solicitation or offer to buy or sell any securities or 
related financial instruments.


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message