ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Les Hughes <leslie.hug...@rubus.com>
Subject RE: [PATCH] p4submit can now update p4.change and set p4.needsres olve property
Date Mon, 13 May 2002 18:41:46 GMT

Hiya,

Sorry, I've only just picked this up - still working on an offline project
:-(
Antoine - thanks for your interest in Ant's Perforce support - I'll have a
go at merging this into 1.5 when it's released (Have I missed that??) plus
anything else you send.


Feel free to start a discussion on ant-dev about any changes you'd like to
see in p4 - I promise I will still be lurking around :-)

Bye,

Les


> -----Original Message-----
> From: Stefan Bodewig [mailto:bodewig@apache.org]
> Sent: 26 April 2002 16:54
> To: Antoine Levy-Lambert
> Cc: ant-dev@jakarta.apache.org; Leslie.hughes@rubus.com
> Subject: Re: [PATCH] p4submit can now update p4.change and set
> p4.needsresolve property
> 
> 
> Hi Antoine,
> 
> many thanks for helping us in the development of Ant.
> 
> We are currently very busy because we want to get Ant 1.5beta ready
> for next week, this also means we are cutting off code changes more or
> less now.  Don't be disappointed if your patch doesn't make it into
> 1.5.
> 
> I don't use perforce myself, so I usually rely on the feedback of
> others before I go ahead and apply patches (and Les is my number one
> choice for feedback here 8-).
> 
> On Fri, 26 Apr 2002, Antoine Levy-Lambert
> <antoine.levy-lambert@db.com> wrote:
> 
> > this is the first time I try to submit something to ant. Let me know
> > if you have any remarks.
> 
> Looks good to me at first glanc, only some minor comments:
> 
> * please don't change the indentation of existing code.
> 
> * you don't seem to be subscribed to ant-dev as I haven't seen your
> mail come in there yet (it is a only subcribers can post list).
> 
> * no need to address people directly in addition to ant-dev.
> 
> > I plan to go on and contribute a number of enhancements to the
> > Perforce tasks in ant.
> 
> Many thanks
> 
>         Stefan
> 

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message