ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Stenglein <d...@sputnik7.com>
Subject Re: [PATCH] Additional testcase for Filter
Date Tue, 21 May 2002 14:29:09 GMT
On Tue, 2002-05-21 at 09:11, Stefan Bodewig wrote:
> On 20 May 2002, David Stenglein <dave@sputnik7.com> wrote:
> 
> > There is no testcase for Filter that covers the use of an external
> > properties file for the definition of filters.
> 
> Thanks, I've committed it.
> 
> > BTW, made this test while modifying filter to accept xmlproperties
> > for filter definitions (which appears to be working).
> 
> I haven't followed this area closely, but I guess you should add this
> to the stuff related to FilterSet rather than the filter task.
> 

Actually, that's what I did. I took the code from XMLproperty and made
a new util.Properties that subclasses java.util.Properties. The
XMLproperty task now uses this as does the FilterSet. Filter needed to
be modified to allow a different format for the properties and to
pass through some XML parsing options.

Does this sound alright?  The only thing that bothers me about this is
adding all of the XML parsing options to the Filter task, and eventually
Replace.

Also, where would this functionality go release-wise, post 1.5?


-Dave



> Stefan
> 
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
-- 
---
David Stenglein
Director of Engineering/Operations
sputnik7.com
dave at sputnik7.com
---



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message