ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <jakarta-...@ehatchersolutions.com>
Subject Re: cvs commit: jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional PropertyFileTest.java
Date Tue, 28 May 2002 21:05:56 GMT
I didn't even look at the patch(es) posted... I just duplicated the bug and
made the fix that was needed.  It was simply that value could be null, and
if so it should just default to incrementing by 1 (operationValue) in that
case.

<propertyfile> is flat out confusing though because of all the bells and
whistles it has.  At least now that we have a good set of test cases we can
reasonably ensure that we won't break it too badly - its just that this one
issue slipped through somehow.  Having 'value' overloaded depending on
whether an operation is happening or not is part of the confusion.

    Erik


----- Original Message -----
From: "Diane Holt" <holtdl@yahoo.com>
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Sent: Tuesday, May 28, 2002 4:59 PM
Subject: Re: cvs commit:
jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional
PropertyFileTest.java


> Guess you decided that was the fix afterall -- okay. Thanks for putting it
through.
>
> =====
> (holtdl@yahoo.com)
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! - Official partner of 2002 FIFA World Cup
> http://fifaworldcup.yahoo.com
>
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message