ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran" <stev...@iseran.com>
Subject Re: [PATCH/CONTRIB] JRun JSPC
Date Sun, 05 May 2002 02:47:05 GMT

----- Original Message -----
From: "Ken Horn" <kenhorn1@yahoo.com>
To: <ant-dev@jakarta.apache.org>
Sent: Friday, May 03, 2002 10:26
Subject: [PATCH/CONTRIB] JRun JSPC


>
> This is a JSPC adapter to use JRun.
>
> It's based on the code from early December. Diffs are included (though
> admittedly without CVS version numbers..).


ok...that code went through quite the rework in late feb, I will see about
reconciliation

> I changed a couple of things in JspC.java, partyl to support filename
mapping -
> JSP to Java,

---since feb each jsp compiler can provide its own implementation of a
filename mapper, we are using the (slightly broken) jasper one by default

>and also to do <%@include .. %> staleness checks (which created a
> dependency on Apache RegEx).

That is nice . It'd be nice to not hard code that requirement in (i.e. with
reflection), but as we are still in the beta state, it may be possible to
get away with adding a new requirement

>
> I haven't had time to keep up with the cvs changes / do the 3.1 change, so
> thought I might as well submit for now..
>
thanks.

I fear that the release police will say 'bug fixes only' at this point in
the game, but I'd be tempted to merge in at least the changes to jspc's
basic classes, so that your stuff drops right in, and the <% include %>
checks go in there too.

Regardless, you do need to bring it up to date wrt. the CVS stuff before I
can work with it, because without jrun myself I'd never know if I was
getting things right

-steve


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message