ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <jakarta-...@ehatchersolutions.com>
Subject Re: cvs commit: jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional PropertyFileTest.java
Date Tue, 28 May 2002 23:12:35 GMT
I read the notes about the hesitation, but because no 'value' attribute was
specified it stayed null because of this:

            private String              value = null;

See?  So I don't understand the confusion about how it got to be null.

    Erik


----- Original Message -----
From: "Diane Holt" <holtdl@yahoo.com>
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Sent: Tuesday, May 28, 2002 6:29 PM
Subject: Re: cvs commit:
jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional
PropertyFileTest.java


> --- Erik Hatcher <jakarta-ant@ehatchersolutions.com> wrote:
> > I didn't even look at the patch(es) posted... I just duplicated the bug
> > and made the fix that was needed.
>
> If you read the bug report you closed with this change, you'll see that
> the point of hesitation about putting through this particular change as
> the fix is whether value (the variable) should ever really be null at that
> point or whether there's a bug in the logic somewhere else along the line
> and this approach to preventing the NPE just masks that.
>
> Diane
>
> =====
> (holtdl@yahoo.com)
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! - Official partner of 2002 FIFA World Cup
> http://fifaworldcup.yahoo.com
>
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message