Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 46665 invoked from network); 11 Apr 2002 14:39:45 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 11 Apr 2002 14:39:45 -0000 Received: (qmail 19179 invoked by uid 97); 11 Apr 2002 14:39:44 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 19163 invoked by uid 97); 11 Apr 2002 14:39:43 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 19152 invoked from network); 11 Apr 2002 14:39:43 -0000 Message-ID: <9B3E950CB293D411ADF4009027B0A4D202E218D5@PARSV011> From: Stephane Bailliez To: Ant Developers List Subject: RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdef s Exit.java Filter.java FixCRLF.java GenerateKey.java Get.java Jar.java Date: Thu, 11 Apr 2002 15:47:39 +0100 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2655.55) Content-Type: text/plain; charset="windows-1252" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N > -----Original Message----- > From: Magesh Umasankar [mailto:umagesh@apache.org] > > > > Which is more important - performance or 80 characters at most per > line? > > I think we should go with private static final Strings in cases > like above and allow them exceed the 80 character limit so as to > get maximum performance. > > I would like us to stick to 80 chars per line only if it > is not going to adversely impact runtime performance. > > Do you agree? No. 1) we are talking about an exceptional situation which is unlikely to happen so performance is not an issue. 2) the static strings will be concatenated at compile time as there is no variables here. check the bytecode with javap -- To unsubscribe, e-mail: For additional commands, e-mail: