Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 79750 invoked from network); 29 Apr 2002 12:14:11 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 29 Apr 2002 12:14:11 -0000 Received: (qmail 14893 invoked by uid 97); 29 Apr 2002 12:14:09 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 14877 invoked by uid 97); 29 Apr 2002 12:14:09 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 14866 invoked from network); 29 Apr 2002 12:14:08 -0000 Message-ID: <000901c1ef78$f3a252a0$0401060a@localdomain> From: "Patrick (Gus) Heck" To: "Ant Developers List" References: <008101c1eeed$2e8ae940$0401060a@localdomain> Subject: Re: [PATCH] DirectoryScanner - adds method setFollowLinks() Date: Mon, 29 Apr 2002 08:25:27 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4807.1700 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N ----- Original Message ----- From: "Stefan Bodewig" To: Sent: Monday, April 29, 2002 6:40 AM Subject: Re: [PATCH] DirectoryScanner - adds method setFollowLinks() > On Sun, 28 Apr 2002, Patrick Heck wrote: > > > This patch allows developers using DirectoryScanner to specify > > whether or not a given instance should report files for which > > File.getCanoniacalPath() and File.getAbsolutePath() are not equal > > (such as symbolic links in linux). > > It seems to work reliably on Unix systems, but I'm afraid it will > break down on certain other systems. AFAIK canonical path and > absolute path may differ in case for Windows for example. > This is something I am uninformed on, particularly with respect to WinXP and the NT series. I have only ever touched one Win2k box, and that is 'managed' by our IT department. I would be very interested to know what the scenario for non-symlink but differing Canonical and Absolute on windows is though (or any other OS). > > The patch also includes a test case for this behavior change. > > Great, thank you. > > You may want to also provide a new followsymlinks attribute to FileSet > so that arbitrary tasks could make use of the new feature without any > changes to the tasks themselves. The "delete follows symlinks" bug > could be fixed that way, for example. > If my patch can be used to fix a bug, that sounds great! I had also thought of doing this, but during the week I will be working on the symlink task since that is what is actually directly relevant to the job I am paid to do :). However I might make this extension to filesets next weekend as a separate patch. > All in all, I'm +1 for your patch, but would really want to have some > people on non-Unix systems (i.e. not me) to see whether it has some > strange side effects for them. > Thanks for the +1 and I am very +1 for it being checked out by people on other OS's (also not me :) ). Gus -- To unsubscribe, e-mail: For additional commands, e-mail: