ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: AntTest Test Failure: WinNT 4.0, JDK 1.3.0_02, 1.4.0_b92
Date Mon, 08 Apr 2002 16:08:32 GMT
On Mon, 8 Apr 2002, Magesh Umasankar <umagesh@apache.org> wrote:

> I closed the stream in Ant.execute and that makes the 
> test pass.  It is also safe because we are explicitly 
> checking to see if logfile (a file) is being used and then
> close it - hence no problem with IDEs.  Shall I go ahead with
> this approach and patch it up?

On second and third thought, yes.

If we use the KeepAliveOutputStream trick, we place the responsibility
for closing the files on the BuildLogger, which didn't open it in the
first place.  Keeping the closing code at the same class that opens
the streams is better IMHO.

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message