ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] DirectoryScanner - adds method setFollowLinks()
Date Mon, 29 Apr 2002 10:40:06 GMT
On Sun, 28 Apr 2002, Patrick Heck <patrick.heck@olin.edu> wrote:

> This patch allows developers using DirectoryScanner to specify
> whether or not a given instance should report files for which
> File.getCanoniacalPath() and File.getAbsolutePath() are not equal
> (such as symbolic links in linux).

It seems to work reliably on Unix systems, but I'm afraid it will
break down on certain other systems.  AFAIK canonical path and
absolute path may differ in case for Windows for example.

> The default value of true, retains the existing behavior

Yes, it should be.

> The patch also includes a test case for this behavior change.

Great, thank you.

You may want to also provide a new followsymlinks attribute to FileSet
so that arbitrary tasks could make use of the new feature without any
changes to the tasks themselves.  The "delete follows symlinks" bug
could be fixed that way, for example.

All in all, I'm +1 for your patch, but would really want to have some
people on non-Unix systems (i.e. not me) to see whether it has some
strange side effects for them.

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message