ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@multitask.com.au
Subject Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional XMLValidateTask.java
Date Mon, 22 Apr 2002 02:30:51 GMT
"Steve Loughran" <steve_l@iseran.com> wrote on 22/04/2002 12:10:47 PM:

> 
> ----- Original Message -----
> From: <ehatcher@apache.org>
> To: <jakarta-ant-cvs@apache.org>
> Sent: Sunday, April 21, 2002 06:46
> Subject: cvs commit:
> jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional
> XMLValidateTask.java
> 
> 
> > ehatcher    02/04/21 06:46:07
> >
> >   Modified:    src/main/org/apache/tools/ant/taskdefs/optional
> >                         XMLValidateTask.java
> >   Log:
> >   Remove Crimson reference, switch to Xerces.
> >
> >   Revision  Changes    Path
> >   1.17      +2 -2
> 
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.
> java
> >
> >   Index: XMLValidateTask.java
> >   ===================================================================
> >   RCS file:
> 
/home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/XMLVal
> idateTask.java,v
> >   retrieving revision 1.16
> >   retrieving revision 1.17
> >   diff -u -r1.16 -r1.17
> >   --- XMLValidateTask.java 20 Apr 2002 16:14:32 -0000 1.16
> >   +++ XMLValidateTask.java 21 Apr 2002 13:46:07 -0000 1.17
> >   @@ -96,9 +96,9 @@
> >         * The default implementation parser classname used by the task 
to
> process
> >         * validation.
> >         */
> >   -    // The crimson implementation is shipped with ant.
> >   +    // The Xerces implementation ships with Ant.
> >        public static String DEFAULT_XML_READER_CLASSNAME
> >   -        = "org.apache.crimson.parser.XMLReaderImpl";
> >   +        = "org.apache.xerces.parsers.SAXParser";
> 
> 
> 1. Do we need to change the docs for this?
> 
> 2. Shouldnt this kind of thing go in a global constants file;
> Constants.java, for all those other tasks that may need to refer to the
> default parser?
Or even better in a properties file, so it can be changed without 
recompiling.
--
dIon Gillard, Multitask Consulting
Work:      http://www.multitask.com.au
Developers: http://adslgateway.multitask.com.au/developers



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message