ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Frederic Lavigne <f...@castify.net>
Subject possible bug in ChangeLog task
Date Wed, 03 Apr 2002 14:45:22 GMT
Hi,

I've tested the changelog and found a possible bug in the log parser.
processGetPreviousRevision method sets the status to GET_COMMENT but it should set it to 
GET_DATE otherwise the date information gets put in the comment and as the author is 
escaped using a CDATA, you finally get a CDATA inside a CDATA...

Am I right ?

Here is the diff between my bug-fixed version and the current cvs version:

Index: ChangeLogParser.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogParser.java,v
retrieving revision 1.4
diff -c -r1.4 ChangeLogParser.java
*** ChangeLogParser.java	2 Apr 2002 08:42:44 -0000	1.4
--- ChangeLogParser.java	3 Apr 2002 14:39:39 -0000
***************
*** 255,261 ****
           saveEntry();

           m_revision = m_previousRevision;
!         m_status = GET_COMMENT;
       }

       /**
--- 255,261 ----
           saveEntry();

           m_revision = m_previousRevision;
!         m_status = GET_DATE;
       }

       /**



Also I've encountered some problems when cvs log is executed. The process hangs forever 
and the changelog command never ends. I modified the Changelog command to send the cvs log

output to a temporary file (I reuse the cvs task for that) and then I pass this file to 
the parser.

best,

-fred


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message