ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magesh Umasankar" <umag...@apache.org>
Subject Re: [PATCH] compression for tar/untar
Date Wed, 24 Apr 2002 03:10:39 GMT
----- Original Message -----
From: "Curt Arnold" <carnold@houston.rr.com>


> I've attached another zip file which contains tests for the tar
compression
> patch.  The actual changes to the tasks are not modified from the previous
> posting.
>
> There is obviously a good reason to desire test cases at the same time as
> the patches, since there is one test case (TarTest.test11) that is failing
> when trying to delete the created tar.bz2 file to clean up the test
> environment.  It appears that CBZip2OutputStream is somehow not closing
the
> FileOutputStream in a timely manner, though a code review of
> CBZip2OutputStream.close() looked okay and the file is usable after the
> completion of the task.
>
> I'm will not be able to spend any time on this for several more hours, if
> anyone knows of any weirdness with CBZip2OutputStream or can quickly
> diagnose the problem, please let me know.  However, I thought it would be
> good to disclose the potential problem as early as possible.
>

I have patched this to CVS head.  Please take a
look to ensure everything is ok.  I have also fixed
the issue found as a result of test11.  It was actually
a problem with CBZip2InputStream.  It wasn't closing
its internal stream before setting it to null.

Thanks for the 'perfect' submission (docs, testcases
et al).  Looking forward to more such stuff from you.

Cheers,
Magesh

***********************************************
* Politics is the gentle art of getting votes *
* from the poor and campaign funds from the   *
* rich, by promising to protect each from the *
* other. --- Oscar Ameringe                   *
***********************************************



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message