Return-Path: 
 <ant-dev-return-28727-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 52760 invoked from network); 27 Mar 2002 05:41:16 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 27 Mar 2002 05:41:16 -0000
Received: (qmail 19512 invoked by uid 97); 27 Mar 2002 05:41:25 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 19466 invoked by uid 97); 27 Mar 2002 05:41:24 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 19455 invoked from network); 27 Mar 2002 05:41:24 -0000
Message-Id: <5.1.0.14.2.20020326230134.054034d0@ingenosya.com>
X-Sender: ingenosya.com:cyrille_list@ingenosya.com
X-Mailer: QUALCOMM Windows Eudora Version 5.1
Date: Tue, 26 Mar 2002 23:41:25 -0600
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
From: Cyrille Morvan <cyrille_list@ingenosya.com>
Subject: RE: [PATCH] : ejbdeploy task
In-Reply-To: <000001c1d547$602905a0$6401a8c0@chris>
References: <000001c1d540$e7bcd520$6401a8c0@chris>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

At 11:25 PM 3/26/2002 -0500, you wrote:
>Ok, my source is all of of sync with CVS, being I moved the packages
>around and renamed.  I have attached an archive of the changes along
>with a diff of the changes I made to the .properties and doc files.  I
>hope this works out.
>
>- Thanks

Hi Chris,

I see that you didn't use my remarks .... Please, use these new ones !!

- Do you think it will work :

<serverdeploy server="http://myserver:9898/weblogicconsole/" source="file" 
action="deploy">
    <weblogic/>
    <jonas/>
    <websphere/>
</serverdeploy>

Sure, it can't, because you can't use the same url to deploy on several 
servers.

So, I repeat, you should move server, username and password from ServerDeploy
to the Abstract class. Or duplicate the username and password properties, 
in the two classes,
and implement a getUsername() and getPassword() in the Abstract class to
read local values before to read the ServerDeploy values.

<serverdeploy source="file" action="deploy">
    <weblogic username="cyrille" 
server="http://myserverONE:9898/weblogicconsole/" />
    <weblogic username="joe" 
server="http://myserverTWO:958/weblogicconsole/" />
    <jonas server="http://myserverThree:8080/jadmin/deploy.jws" />
</serverdeploy>

- Do you think it's a good :

<serverdeploy source="file" action="deploy">
    <weblogic username="cyrille" 
server="http://myserverOne:9898/weblogicconsole/" />
    <websphere username="joe" 
server="http://myserverTWO:958/weblogicconsole/" />
    <jonas server="http://myserverThree:8080/jadmin/deploy.jws" />
    <classpath>
         <include>/weblogic/lib/*.jar</include>
         <include>/websphere/lib/*.jar</include>
         <include>/jonas/lib/*.jar</include>
    </classpath>
</serverdeploy>

No because, we will have conflict with jndi.properties files and other stuffs.

I prefer this :

<serverdeploy source="file" action="deploy">
    <weblogic username="cyrille" 
server="http://myserverOne:9898/weblogicconsole/" >
        <classpath>
         <include>/weblogic/lib/*.jar</include>
        </classpath>
    </weblogic>

    <websphere username="joe" 
server="http://myserverTwo:958/weblogicconsole/" >
        <classpath>
         <include>/websphere/lib/*.jar</include>
        </classpath>
    </websphere>

    <jonas server="http://myserverThree:8080/jadmin/deploy.jws" 
jonasroot="/jonas" />

   <classpath>
     <include>anything else</include>
   </classpath>

</serverdeploy>

- The abstract class should provide a default deploy() implementation.
Using abstract method to construct the java task.

- And at the end. The static values for the action, should no be in 
WebLogic class, but in the interface
or the abstract class ,because all the implementation need it.

Thanks.


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>