Return-Path: 
 <ant-dev-return-27716-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 17380 invoked from network); 14 Mar 2002 12:35:22 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 14 Mar 2002 12:35:22 -0000
Received: (qmail 9311 invoked by uid 97); 14 Mar 2002 12:35:17 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 9296 invoked by uid 97); 14 Mar 2002 12:35:17 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 9284 invoked from network); 14 Mar 2002 12:35:16 -0000
Message-ID: <3C909967.6060005@gaussvip.com>
Date: Thu, 14 Mar 2002 13:36:55 +0100
From: "Sascha Woyde" <sascha.woyde@gaussvip.com>
MIME-Version: 1.0
To: ant-dev@jakarta.apache.org
Subject: Zip task bug in 1.4.1
Content-Type: multipart/mixed;
 boundary="------------050102010804030209000500"
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

--------------050102010804030209000500
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,
The bug documented as

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5092

for ANT 1.5 nightly builds also appears in 1.4.1

It's a bug in class org.apache.tools.ant.taskdefs.Zip, resulting in
the <jar> task always rebuilding jars, even when update="true"
is selected.

I have created a patch to apply the resolution proposed in bug 5092
to 1.4.1 (see attached).

What's the desired way of handling this. Shall I open a new bugzilla
entry, this time for 1.4.1 and append the patch to it?
What about 1.4 then?

Thanks,
Sascha

-- 

Sascha Woyde

Configuration Management

Gauss Interprise AG
Research & Development
mail: sascha.woyde@gaussvip.com
http://www.gaussvip.com

Visit us at our CeBIT booth (13th - 20th March) in Hannover, hall 6 - booth C11.



--------------050102010804030209000500
Content-Type: text/plain;
 name="uptodatePatch.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="uptodatePatch.txt"

--- origZip.java	Thu Oct 11 22:58:30 2001
+++ patchedZip.java	Thu Mar 14 11:25:29 2002
@@ -194,6 +194,25 @@
             throw new BuildException("You must specify the " + archiveType + " file to create!");
         }
 
+        // Create the scanners to pass to isUpToDate().
+        Vector dss = new Vector ();
+        if (baseDir != null) {
+            dss.addElement(getDirectoryScanner(baseDir));
+        }
+        for (int i=0; i<filesets.size(); i++) {
+            FileSet fs = (FileSet) filesets.elementAt(i);
+            dss.addElement (fs.getDirectoryScanner(project));
+        }
+        int dssSize = dss.size();
+        FileScanner[] scanners = new FileScanner[dssSize];
+        dss.copyInto(scanners);
+
+        // quick exit if the target is up to date
+        // can also handle empty archives
+        if (isUpToDate(scanners, zipFile)) {
+            return;
+        }
+
         // Renamed version of original file, if it exists
         File renamedFile = null;
         // Whether or not an actual update is required -
@@ -230,25 +249,6 @@
             }
         }
         
-        // Create the scanners to pass to isUpToDate().
-        Vector dss = new Vector ();
-        if (baseDir != null) {
-            dss.addElement(getDirectoryScanner(baseDir));
-        }
-        for (int i=0; i<filesets.size(); i++) {
-            FileSet fs = (FileSet) filesets.elementAt(i);
-            dss.addElement (fs.getDirectoryScanner(project));
-        }
-        int dssSize = dss.size();
-        FileScanner[] scanners = new FileScanner[dssSize];
-        dss.copyInto(scanners);
-
-        // quick exit if the target is up to date
-        // can also handle empty archives
-        if (isUpToDate(scanners, zipFile)) {
-            return;
-        }
-
         String action = reallyDoUpdate ? "Updating " : "Building ";
         
         log(action + archiveType +": "+ zipFile.getAbsolutePath());


--------------050102010804030209000500
Content-Type: text/plain; charset=us-ascii

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
--------------050102010804030209000500--