Return-Path: 
 <ant-dev-return-27515-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 68648 invoked from network); 9 Mar 2002 01:13:18 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 9 Mar 2002 01:13:18 -0000
Received: (qmail 2316 invoked by uid 97); 9 Mar 2002 01:13:23 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 2293 invoked by uid 97); 9 Mar 2002 01:13:22 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 2226 invoked by uid 97); 9 Mar 2002 01:13:22 -0000
Date: 9 Mar 2002 01:13:12 -0000
Message-ID: <20020309011312.78952.qmail@icarus.apache.org>
From: umagesh@apache.org
To: jakarta-ant-cvs@apache.org
Subject: cvs commit: jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs
 LoadFileTest.java
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

umagesh     02/03/08 17:13:12

  Modified:    src/testcases/org/apache/tools/ant/taskdefs
                        LoadFileTest.java
  Log:
  Use assertEquals instead of explicit check/fail combo.
  
  Revision  Changes    Path
  1.8       +7 -7      jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/LoadFileTest.java
  
  Index: LoadFileTest.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/LoadFileTest.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- LoadFileTest.java	7 Mar 2002 19:42:30 -0000	1.7
  +++ LoadFileTest.java	9 Mar 2002 01:13:12 -0000	1.8
  @@ -62,6 +62,7 @@
    * Test the load file task
    *
    * @author Steve Loughran
  + * @author <a href="mailto:umagesh@apache.org">Magesh Umasankar</a>
    * @created 10 December 2001
    */
   public class LoadFileTest extends BuildFileTest {
  @@ -163,7 +164,7 @@
       }
   
       /**
  -     * A unit test for JUnit
  +     * Test FilterChain and FilterReaders
        */
       public void testFilterChain()
               throws BuildException {
  @@ -174,15 +175,14 @@
       }
   
       /**
  -     * A unit test for JUnit
  +     * Test StripJavaComments filterreader functionality.
        */
  -    public void testStripJavaComments()
  +    public final void testStripJavaComments()
               throws BuildException {
           executeTarget("testStripJavaComments");
  -        String expected = project.getProperty("expected");
  -        if(!project.getProperty("testStripJavaComments").equals(expected)) {
  -            fail("StripJavaComments broken");
  -        }
  +        final String expected = project.getProperty("expected");
  +        final String generated = project.getProperty("testStripJavaComments");
  +        assertEquals(expected, generated);
       }
   
       /**
  
  
  

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>