Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 87280 invoked from network); 1 Mar 2002 11:27:40 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 1 Mar 2002 11:27:40 -0000 Received: (qmail 26695 invoked by uid 97); 1 Mar 2002 11:27:43 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 26620 invoked by uid 97); 1 Mar 2002 11:27:42 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 26533 invoked from network); 1 Mar 2002 11:27:42 -0000 Message-Id: <200203011127.g21BReZ10744@mail012.syd.optusnet.com.au> Content-Type: text/plain; charset="utf-8" From: Peter Donald To: "Ant Developers List" Subject: Re: cvs commit: jakarta-ant/proposal/myrmidon/src/testcases/org/apache/myrmidon/components/deployer DefaultDeployerTest.java TestConverter1.java Date: Fri, 1 Mar 2002 22:23:47 +1100 X-Mailer: KMail [version 1.3.2] References: In-Reply-To: X-Wisdom-Cookie: . MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Mon, 25 Feb 2002 22:02, Adam Murdoch wrote: > > -----Original Message----- > > From: adammurdoch@apache.org [mailto:adammurdoch@apache.org] > > Sent: Monday, 25 February 2002 8:43 PM > > To: jakarta-ant-cvs@apache.org > > Subject: cvs commit: > > jakarta-ant/proposal/myrmidon/src/testcases/org/apache/myrmidon/componen > > ts/deployer DefaultDeployerTest.java TestConverter1.java > > > > > > > > Log: > > Replaced usage of Avalon Context with Myrmidon specific Context: > > I wasn't really planning to do this, but hooked into it when I found that > the converters weren't being handed a TaskContext in the new places where > conversion is happening. It wasn't till I was almost done that I > discovered TaskContextAdaptor.resolve(). Too late by that stage, the > changes were all mixed up in the other stuff, so I kept going. Blech. Really don't like this. Complicates the task API for little benefit IMHO. If we were going to bind to ants specific notiong of a context then we should bind directly to TaskContext. > Personally, I prefer this approach, rather than adapting back and forwards > between TaskContext and Avalon Context. Resolvable and Context are just a > bit too general for my taste. However, I can roll this particular change > back, if there's some compelling reason to go with the Avalon Context. +1 to a revert. It is ugly now but I plan to rework this in the future to make it easier to use. The main reason it is general is so that it it can be used outside of ant with minimal interlinking. Similar to how the Converter architecture is largely (all?) decoupled from ant/avalon atm. So it may not be perfect now but I don't think creating a new Context object is the correct answer. -- Cheers, Pete When a stupid man is doing something he's ashamed of, he always declares that it is his duty. George Bernard Shaw -- To unsubscribe, e-mail: For additional commands, e-mail: