Return-Path: 
 <ant-dev-return-28566-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 45431 invoked from network); 25 Mar 2002 06:08:11 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 25 Mar 2002 06:08:10 -0000
Received: (qmail 18625 invoked by uid 97); 25 Mar 2002 06:08:18 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 18609 invoked by uid 97); 25 Mar 2002 06:08:17 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 18598 invoked from network); 25 Mar 2002 06:08:17 -0000
Message-ID: <02b701c1d3c3$73ef9890$6501a8c0@darden.virginia.edu>
From: "Erik Hatcher" <jakarta-ant@ehatchersolutions.com>
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
References: <auto-000003981610@einsurance.de>
Subject: Re: PATCH: <record> support for emacs mode
Date: Mon, 25 Mar 2002 01:08:15 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2600.0000
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

Feedback inline below....

----- Original Message -----
From: "stephan beal" <stephan@wanderinghorse.net>
To: <ant-dev@jakarta.apache.org>
Sent: Sunday, March 24, 2002 8:34 PM
Subject: PATCH: <record> support for emacs mode


> Summary:
> Patches to Main, Project, Recorder and RecorderEntry to enable <record>
tasks
> to take advantage of the -emacs command-line flag. Also adds <record
> emacsmode='boolean'.../>  support. It's backwards-compatible except that
it
> fixes the bug that <record> didn't do emacs ;).
>
> IF the -emacs command-line parm is passed, that will override the default
> value for this setting (false) IF this object's XML representation does
> NOT specify a preference. If it specifies any preference, that will take
> precendent over the command-line parameter.
>
>
> This supercedes any earlier patch i sent for this.

Index: src/main/org/apache/tools/ant/Main.java
===================================================================

+ // quick hack to enable emacsMode in RecorderEntry
(stephan@wanderinghorse.net)
+ project.setProperty( Project.EMACS_MODE_FLAG, new
java.lang.Boolean(this.emacsMode).toString() );

No "quick hack" is going to get committed by me!  :)   (again, its a
comments issue - keep it professional)

Perhaps this flag should just become a getter/setter on Project?


Index: src/main/org/apache/tools/ant/Project.java
===================================================================
+    /**
+     * Quick hack to enable emacsMode in RecorderEntry
(stephan@wanderinghorse.net)
+     * This is not in Main because Task doesn't need to know about Main,
and i don't
+     * want to make it know about Main just to see this flag.
+     */
+    public final static String EMACS_MODE_FLAG = "ant.emacsmode";

Again, perhaps getter/setter for this would be better than a 'hack' through
the properties.


Index: src/main/org/apache/tools/ant/taskdefs/Recorder.java
===================================================================
+    /**
+     * Duh.
+     */
+    public boolean getEmacsmode() {
+ return this.emacsMode;
+    }

Why do you need this?  Is it used somewhere?

    Erik


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>