ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stephan beal <step...@wanderinghorse.net>
Subject Re: DO NOT REPLY [Bug 7482] - PatternSet.setIncludes() does not SET includes, but appends them to a list
Date Wed, 27 Mar 2002 12:13:53 GMT
On Wednesday 27 March 2002 12:14 pm, Adam Murdoch wrote:
> > -----Original Message-----
> > From: stephan beal [mailto:stephan@wanderinghorse.net]
> > Sent: Wednesday, 27 March 2002 8:43 PM
> > To: Ant Developers List
> > Subject: Re: DO NOT REPLY [Bug 7482] - PatternSet.setIncludes() does not
> > SET includes, but appends them to a list
> >
> > On Wednesday 27 March 2002 07:34 am, Adam Murdoch wrote:
> > > Why you can't create a new Jar object for each iteration?
> >
> > a) it's just fun to hack ant ;)
> > b) i could, but it'd require more re-configuration of each object than i
> > really wanted to deal with.
>
> Honestly, don't you think it'd would be simpler if you just wrote the half
> a dozen lines of code that you'd need to create and configure a new Jar
> object for each iteration?

Yes, IF getter functions existed in Jar and Zip for the basic zip/jar 
properties. i cannot, using the current Jar code, get my 'jarfile' 
('destfile') flag, for example, so i cannot reconfigure multiple objects 
using those flags. How can i reconfigure the object when i cannot get at that 
object's own data (no getters are supplied)? One option is to override the 
setters and make local copies of those properties, but for reasons i pointed 
out yesterday, this is a patentedly Bad Idea.

> The changes you're talking about to MatchingTask/FileSet/PatternSet just
> don't seem to be worth the effort we'd need to put into applying, testing,
> documenting and maintaining them.  

All i'm suggesting is one reset method, which would (in theory) only be used 
by developers, not via tasks.

> Adding more methods just adds interia to
> these types (which is something I'd be reluctant to see happen, having just
> spent the last 3 weeks untangling these types in myrmidon), and the benefit
> is questionable at best.

i can understand that.

----- stephan
Generic Unix Computer Guy
stephan@einsurance.de - http://www.einsurance.de
Office: +49 (89)  552 92 862 Handy:  +49 (179) 211 97 67
"...control is a degree of inhibition, and a system which is perfectly
inhibited is completely frozen." -- Alan W. Watts

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message