ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stephan beal <step...@wanderinghorse.net>
Subject Re: [Bug 7482] - PatternSet.setIncludes() does not SET includes, but appends them to a list
Date Tue, 26 Mar 2002 17:55:20 GMT
On Tuesday 26 March 2002 17:58 pm, Erik Hatcher wrote:
> no need to use getProject, its a member variable of Task: project.  Just an
> FYI.

i firmly believe that public/protected data are *Evil*. When possible i use 
only accessor functions, even interally, for maximum (warning: swear word) 
subclassibility. (And no, i've never had a problem with subclasses hosing 
stuff this way - i've had nothing but good experiences with this approach.)

> You sure do enjoy making life more difficult on yourself, don't you?!   :)
>
> You jump through all sorts of hoops - and there is certainly easier ways to
> do what you're doing.  I don't have the time to think through your very
> non-standard probably-never-to-be-added-to-Ant-core <jar> hack, but you've

i subclassed - no core changes.

> got to work with PatternSet as it exists - those setters are functioning as
> they should. Think about it from the XML introspection perspective and
> you'll hopefully see what I mean.

Maybe they work as they should, but not as they are documented. Set != append.

>     <patternset id="patternset" includes="....">
>         <include name="..."/>
>     </patternset>
>
> Which of those patterns should it use? The one from the attribute?  Or the
> nested element?  Or both?  If both, how will they get appended together? 
> :)

That's an internal detail which i, as a user, should not need to concern 
myself with ;). i see your point, though.


----- stephan
Generic Unix Computer Guy
stephan@einsurance.de - http://www.einsurance.de
Office: +49 (89)  552 92 862 Handy:  +49 (179) 211 97 67
"...control is a degree of inhibition, and a system which is perfectly
inhibited is completely frozen." -- Alan W. Watts

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message