ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stephan beal <step...@wanderinghorse.net>
Subject Re: new feature: RecorderEntry accepts -emacs
Date Fri, 22 Mar 2002 00:21:30 GMT
On Friday 22 March 2002 01:19, you wrote:
> ----- Original Message -----
> From: "stephan beal" <stephan@wanderinghorse.net>
>
> > org.apache.tools.ant.util.StringUtils:
> > added
> >     public static boolean getBooleanValue( String s );
> >     public static String getStringValue( boolean b );
> >
> > They treat the following String values as boolean true
> > (case-insensitive): true, on, yes, 1, yessireebob (no, i'm not kidding)
>
> Congratulations!  You've just recreated Project.toBoolean :))

i KNEW this had to exist somewhere. i KNEW it. Errr... but i was lazy.

> > ---------------------------------
> > public static final String EMACS_MODE_FLAG = "emacsMode";
>
> Since you're making this a property, it should be prefixed with "ant.", and
> probably not have uppercase characters just to stay consistent.
> ant.emacs.mode

Sounds good. i'll make the change in the morning (bed time now).

> > org.apache.tools.ant.RecorderEntry:
> > - now applies emacsMode check to all log() and messageLogged() calls
> > (even debuggering calls to log() ).
>
> But shouldn't you take into account the setEmacsMode setting of
> RecorderEntry?!

It's set via the -emacs command line, "inherited" from Project in 
Project.addBuildListener(). Since that's practically the only way this class 
gets instantiated, that didn't seem too terrible. RecorderEntry did not 
implement emacsMode behaviour inherently. If it is set in the task, then that 
will override the value from Project:
<record emacsMode="true" .../>
will take priority (in theory... but i don't see why it won't do so). The 
function setEmacsMode( boolean ) exists from the BuildLogger interface.


----- stephan@wanderinghorse.net
http://qub.sourceforge.net  - http://radioaqtiph.sourceforge.net
http://www.countermoves.net - http://stephan.rootonfire.org
"Unix: the shell is your oyster."




--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message