ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@multitask.com.au
Subject Re: NetRexxC-diff [Viruschecked] [Viruschecked] [Viruschecked]
Date Sat, 30 Mar 2002 16:02:14 GMT
"Patric Bechtel" <bechtel@ipcon.de> wrote on 31/03/2002 01:42:20 AM:

> On Sun, 31 Mar 2002 00:40:45 +1000, dion@multitask.com.au wrote:
> 
> Do you need the complete fix?

Hey, I'm not an ant committer, just the original author of the NetRexxC 
task, and a NetRexx user!

But to get things committed, it'd be best to resend the patch in full, 
against the CVS version of the code.

> 
> tia
> 
> Patric
> 
> >"Patric Bechtel" <bechtel@ipcon.de> wrote on 31/03/2002 12:12:39 AM:
> >
> >> On Sun, 31 Mar 2002 00:09:31 +1000, dion@multitask.com.au wrote:
> >> 
> >> Hallo dion,
> >> 
> >> there IS a need to chunk lines, as some IDE's try to register itself
> >> on the log events, which should have one line after another.
> >> Your approach to simply flush the stream into the log is not so
> >> nice for their approach. What about the folks which don't use
> >> simple command lines, but Swing gui's, which try to color each
> >> line depending on it's severity?
> >Sounds like a good reason to me :)
> >
> >> Ok, let's take a look on this:
> >> 
> >> -                    log(lb.toString(), Project.MSG_ERR);
> >> +                    if (lb.indexOf("Error")!=-1) {
> >> +                        log(lb.toString(), Project.MSG_ERR);
> >> +                    } else if (lb.indexOf("Warning")!=-1) {
> >> +                        log(lb.toString(), Project.MSG_WARN);
> >> +                    } else {
> >> +                        log(lb.toString(), Project.MSG_INFO);
> >> +                    }
> >> 
> >> Now there would be a nice colored output when compact="true" is set,
> >> line by line, each with it's own severity.
> >> Also, the adornments are visible on each line, which is also 
important
> >> for matchers, which rely on that.
> >> 
> >> What do you think?
> >Even better.
> >

--
dIon Gillard, Multitask Consulting
Work:      http://www.multitask.com.au
Developers: http://adslgateway.multitask.com.au/developers


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message