ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Murdoch" <adammurdoch...@yahoo.com>
Subject RE: cvs commit: jakarta-ant/proposal/myrmidon/src/java/org/apache/antlib/core PropertyDump.java
Date Fri, 22 Mar 2002 02:26:18 GMT


> -----Original Message-----
> From: Peter Donald [mailto:peter@apache.org]
> Sent: Friday, 22 March 2002 9:48 AM
> To: Ant Developers List
> Subject: Re: cvs commit:
> jakarta-ant/proposal/myrmidon/src/java/org/apache/antlib/core
> PropertyDump.java
> 
> 
> On Thu, 21 Mar 2002 20:42, Adam Murdoch wrote:
> > > -----Original Message-----
> > > From: donaldp@apache.org [mailto:donaldp@apache.org]
> > >
> > >
> > >       /**
> > >        * Printout all the properties in ant runtime.
> > >        */
> > >       public void execute()
> > >       {
> > >           final Map properties = getContext().getProperties();
> > >           final Iterator iterator = properties.keySet().iterator();
> > >           while( iterator.hasNext() )
> > >           {
> > >               final String key = (String)iterator.next();
> > >               final Object value = properties.get( key );
> > >               getContext().warn( key + "=" + value );
> > >           }
> > >       }
> >
> > I wonder whether it's time for a new log level.  It strikes me 
> as kinda odd
> > that we have to use warn() rather than info() to write info 
> messages that
> > we want to appear when not running --verbose.  We probably want to pull
> > info() and warn() up, and add a verbose() or verboseInfo() 
> between debug()
> > and info().
> 
> How about
> 
> debug()    (full debug output - meant for task writers)
> verbose()  (printout when verbose - useful to get more 
> information without 
> being flooded - still meant for build file writers)
> info()     (regular printout)
> warn()     (Something bad occured like unable to delete file no 
> stop build)
> error()    (Stop the compile errors)
> 

+1, much better.


> > Thoughts?  How is this going to work with Logger?
> 
> Bump everything up a level after debug(). ie error --> 
> Logger.fatalError(), 
> warn --> Logger.error() etc.
> 

Sure, that's still kinda wierd for component writers.  But that's not quite so important,
I guess.


Adam


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message