ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cyrille Morvan <cyrille_l...@ingenosya.com>
Subject RE: [PATCH] : ejbdeploy task
Date Wed, 27 Mar 2002 05:41:25 GMT
At 11:25 PM 3/26/2002 -0500, you wrote:
>Ok, my source is all of of sync with CVS, being I moved the packages
>around and renamed.  I have attached an archive of the changes along
>with a diff of the changes I made to the .properties and doc files.  I
>hope this works out.
>
>- Thanks

Hi Chris,

I see that you didn't use my remarks .... Please, use these new ones !!

- Do you think it will work :

<serverdeploy server="http://myserver:9898/weblogicconsole/" source="file" 
action="deploy">
    <weblogic/>
    <jonas/>
    <websphere/>
</serverdeploy>

Sure, it can't, because you can't use the same url to deploy on several 
servers.

So, I repeat, you should move server, username and password from ServerDeploy
to the Abstract class. Or duplicate the username and password properties, 
in the two classes,
and implement a getUsername() and getPassword() in the Abstract class to
read local values before to read the ServerDeploy values.

<serverdeploy source="file" action="deploy">
    <weblogic username="cyrille" 
server="http://myserverONE:9898/weblogicconsole/" />
    <weblogic username="joe" 
server="http://myserverTWO:958/weblogicconsole/" />
    <jonas server="http://myserverThree:8080/jadmin/deploy.jws" />
</serverdeploy>

- Do you think it's a good :

<serverdeploy source="file" action="deploy">
    <weblogic username="cyrille" 
server="http://myserverOne:9898/weblogicconsole/" />
    <websphere username="joe" 
server="http://myserverTWO:958/weblogicconsole/" />
    <jonas server="http://myserverThree:8080/jadmin/deploy.jws" />
    <classpath>
         <include>/weblogic/lib/*.jar</include>
         <include>/websphere/lib/*.jar</include>
         <include>/jonas/lib/*.jar</include>
    </classpath>
</serverdeploy>

No because, we will have conflict with jndi.properties files and other stuffs.

I prefer this :

<serverdeploy source="file" action="deploy">
    <weblogic username="cyrille" 
server="http://myserverOne:9898/weblogicconsole/" >
        <classpath>
         <include>/weblogic/lib/*.jar</include>
        </classpath>
    </weblogic>

    <websphere username="joe" 
server="http://myserverTwo:958/weblogicconsole/" >
        <classpath>
         <include>/websphere/lib/*.jar</include>
        </classpath>
    </websphere>

    <jonas server="http://myserverThree:8080/jadmin/deploy.jws" 
jonasroot="/jonas" />

   <classpath>
     <include>anything else</include>
   </classpath>

</serverdeploy>

- The abstract class should provide a default deploy() implementation.
Using abstract method to construct the java task.

- And at the end. The static values for the action, should no be in 
WebLogic class, but in the interface
or the abstract class ,because all the implementation need it.

Thanks.


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message