ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dIon Gillard <d...@multitask.com.au>
Subject Re: [PATCH] XCatalog - Fixed bugs in XCatalog.java
Date Wed, 06 Mar 2002 20:10:14 GMT
Conor MacNeill wrote:

> Dion,
>
> I have committed this code with a few modifications. If you disagree 
> with any let me know.
>
> I extracted DTD as a top-level class rather than an inner class, 
> reverting to the original ejbjar name of DTDLocation, since I thought 
> that was a more accurate name. The intent here is to cut down 
> repitition by pulling the versions in ejbjar and XMLValidate to all 
> refer to this one class. 

No problem on this.

> I am wondering about the name xcatalog - what does it mean? It doesn't 
> really suggest the function that this datatype fills. Any ideas? 

It's from the original XCatalog proposal to the w3c. See 
http://www.ccil.org/~cowan/XML/XCatalog.html . This has since been 
renamed XMLCatalog. To quote: "XML Catalogs are Web resources (anything 
from local files on up) which contain mappings from public identifiers 
to system identifiers (and optionally mappings from system identifiers 
to other system identifiers), plus references to other XML Catalogs"

Maybe we should rename it XMLCatalog?

The idea originally was to create a simple way of providing XCatalog 
functionality in Ant, and later actually support XCatalog files.

> I changed the createXXX to addXXX for the reasons I explained earlier 
> today. 

Fine on that one.

> I think it will be good to be able to merge xcatalogs into a single 
> catalog since you need to ue a single resolver (I see that now :-)). 
> For example in ejbjar, I will probably nest an xcatalog and add the 
> <dtd> elements to this catalog but I would also like to accept nested 
> xcatalogs or xcatalog references. I need to merge these catalogs into 
> a single execute-time catalog to give the parser. 

This makes sense. How does this work with <classpath>s? I was thinking 
they were similar in what they did; classpaths aggregate pathelements, 
filesets etc. Having nested xcatalogs seems reasonable though.

> I'll tackle the ejbjar refactor tomorrow and maybe XMLValidate unless 
> you want to jump in before me. 

Go for it :)

> BTW, I tested this on the latka doc-xslt target. Major speed improvement. 

Yep, it's lots better than going to the net the whole time...

> Conor

-- 
dIon Gillard, Multitask Consulting
http://adslgateway.multitask.com.au/developers




--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message