ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Conor MacNeill <co...@cortexebusiness.com.au>
Subject Re: [PATCH] XCatalog - Fixed bugs in XCatalog.java
Date Tue, 05 Mar 2002 14:05:56 GMT
Dion,

I have committed this code with a few modifications. If you disagree 
with any let me know.

I extracted DTD as a top-level class rather than an inner class, 
reverting to the original ejbjar name of DTDLocation, since I thought 
that was a more accurate name. The intent here is to cut down repitition 
by pulling the versions in ejbjar and XMLValidate to all refer to this 
one class.

I am wondering about the name xcatalog - what does it mean? It doesn't 
really suggest the function that this datatype fills. Any ideas?

I changed the createXXX to addXXX for the reasons I explained earlier today.

I think it will be good to be able to merge xcatalogs into a single 
catalog since you need to ue a single resolver (I see that now :-)). For 
example in ejbjar, I will probably nest an xcatalog and add the <dtd> 
elements to this catalog but I would also like to accept nested 
xcatalogs or xcatalog references. I need to merge these catalogs into a 
single execute-time catalog to give the parser.

I'll tackle the ejbjar refactor tomorrow and maybe XMLValidate unless 
you want to jump in before me.

BTW, I tested this on the latka doc-xslt target. Major speed improvement.

Conor


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message