ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 7433] New: - <commandline> support for AbstractCvsTask
Date Mon, 25 Mar 2002 08:49:28 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7433>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7433

<commandline> support for AbstractCvsTask

           Summary: <commandline> support for AbstractCvsTask
           Product: Ant
           Version: 1.5 alpha (nightly)
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Core tasks
        AssignedTo: ant-dev@jakarta.apache.org
        ReportedBy: stephan@wanderinghorse.net


Overview of changes:

Commandline:
- added createArgument( boolean insertAtStart ). createArgument() now calls 
createArgument( false ). This allows args to be inserted at the beginning of 
the args list (some Cvs flags need to be first in line, as do some rsync and 
webalizer args). i know this is backwards-compatible because i actually broke 
the Javac task while making this change, and had to fix it. i would like to 
add createArgument( int index ), but i'm not up for that much error handling 
this late at night ;).

AbstractCvsTask: (requires the above Commandline changes)
(all changes are backwards-compatible)
- Added property: compression={number 1-9 or boolean}. Adds -zN to the 
command line.
- "command-global" properties, like cvsRoot and compression are passed on to 
each command line.
- Refactoring to allow better re-use of Environment "global" Commandline 
prorties (like cvsRoot and cvsPackage).
- Cvs commands are now accepted in 3 different formats:
1) command='...'
2) character data (one cvs command per line).
3) <commandline> child elements.

An example shows it best:

<cvs failonerror='true' 
                compression='true'
                >
        <commandline>
                <argument value='update'/>
                <argument value='-r'/>
                <argument value='1.268'/>
                <!-- alternately, value='-rTAG', with no space.  -->
                <argument value='build.xml'/>
        </commandline>
        <commandline>
                <argument value='update'/>
                <argument value='-r'/> 
                <argument value='HEAD'/>
                <argument value='build.xml'/>
        </commandline>
        <commandline>
                <argument line='log -r1.5 build.xml'/>
        </commandline>
<![CDATA[
status src/main/org/apache/tools/ant/taskdefs/AbstractCvsTask.java
]]>
</cvs>

command=... is run first.
<commandline> is run second.
character data commands are run last.

command=... becomes optional if one of the other two forms are used, and 
defaults to 'checkout' (legacy behaviour) if no command-input method is used 
(in legacy terms, if no command is set). The command property is no longer 
ignored if character data is set (as it was in my last patch).

It is completely backwards-compatible with the AbstractCvsTask, it only adds 
new functionality. i find the legacy default behaviour odd (checkout? 
shouldn't it be update, if anything?).

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message