ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <pe...@apache.org>
Subject Re: cvs commit: jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/components/embeddor DefaultEmbeddor.java
Date Sat, 23 Mar 2002 13:31:13 GMT
On Sat, 23 Mar 2002 21:56, Adam Murdoch wrote:
> Absolutely.  I actually meant we should split TypeManager into 2
> interfaces, and split RoleManager into 2 interfaces, but keep
> DefaultTypeManager and DefaultRoleManager as they are.

Ahh I c what you mean. One little thing though. You seem to have it backwards 
- ie Your Registry had the factory method and your Manager had the register 
method. Shouldn't the register method be part of registry and factory method 
be part of the Manager ? ;)

> So, something like this:
>
> TypeManager gets split into:
>
> interface TypeRegistry
> {
>     TypeFactory getFactory( roleName );
> }
>
> interface TypeManager
> {
>     void registerType( roleName, typeName, typeFactory );
> }
>
> And RoleManager gets split into:
>
> interface RoleRegistry
> {
>     RoleInfo getRole...( ... );
> }
>
> interface RoleManager
> {
>     void registerRole( roleInfo )
> }
>
>
> Adam

-- 
Cheers,

Pete

----------------------------------------------------------------
Fools ignore complexity.  Pragmatists suffer it.
Some can avoid it.  Geniuses remove it.
-- Perlis's Programming Proverb #58, SIGPLAN Notices, Sept. 1982
----------------------------------------------------------------


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message