ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darrell DeBoer <darr...@apache.org>
Subject Re: [myrmidon] PATCH: NameValidator (modified)
Date Wed, 13 Mar 2002 01:16:40 GMT
On Wed, 13 Mar 2002 08:35, Peter Donald wrote:
> On Sun, 10 Mar 2002 23:38, Darrell DeBoer wrote:
> > BTW, I didn't modify the ProjectBuilder interface, as this would require
> > adding this exception to the public API. Maybe it should be, but I'll
> > leave that decision to those more familiar with the package structure.
>
> Kool - will add it if Adam hasn't got to it yet.
>
> > On a similar note: the NameValidator class is used by both
> > myrmidon.components.DefaultProjectBuilder and
> > myrmidon.components.DefaultTaskContext. Where should code like this go?
>
> generally something that is used by multiple areas would be put into a new
> package hierarchy such as
>
> myrmidon.components.validator.NameValidator
>
> or something.

Adam's already committed this, but I guess you'll want to move it. (In future 
patches, I'll just add stuff closest to where it's used, and let you move it 
around with Intellij when/after you guys commit it (until I get more 
comfortable with the "myrmidon-way", that is).

ciao
Daz 

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message