ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsk...@apache.org
Subject cvs commit: jakarta-ant/src/main/org/apache/tools/ant XmlLogger.java
Date Sun, 03 Mar 2002 10:06:31 GMT
jskeet      02/03/03 02:06:31

  Modified:    src/main/org/apache/tools/ant XmlLogger.java
  Log:
  Answered my own previous question concerning thread safety.
  
  Revision  Changes    Path
  1.24      +7 -9      jakarta-ant/src/main/org/apache/tools/ant/XmlLogger.java
  
  Index: XmlLogger.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/XmlLogger.java,v
  retrieving revision 1.23
  retrieving revision 1.24
  diff -u -r1.23 -r1.24
  --- XmlLogger.java	1 Mar 2002 16:28:43 -0000	1.23
  +++ XmlLogger.java	3 Mar 2002 10:06:30 -0000	1.24
  @@ -74,7 +74,13 @@
    * Generates a file in the current directory with
    * an XML description of what happened during a build.
    * The default filename is "log.xml", but this can be overridden
  - * with the property <code>XmlLogger.file</code>
  + * with the property <code>XmlLogger.file</code>.
  + * 
  + * This implementation assumes in its sanity checking that only one 
  + * thread runs a particular target/task at a time. This is enforced
  + * by the way that parallel builds and antcalls are done - and
  + * indeed all but the simplest of tasks could run into problems
  + * if executed in parallel.
    *
    * @see Project#addBuildListener(BuildListener)
    */
  @@ -119,14 +125,6 @@
   
       /** The complete log document for this build. */
       private Document doc = builder.newDocument();
  -    // XXX: (Jon Skeet) I don't see the use for these maps, myself,
  -    // and they don't seem threadsafe to me. Is there something
  -    // preventing a task being executed by two different threads
  -    // at the same time? If not, we could get a mismatch error
  -    // for no good reason. I'd have thought that checking
  -    // the information in the element stored in the TimedElement
  -    // would give enough of a validity check and end up being more 
  -    // threadsafe.
       /** Mapping for when tasks started (Task to TimedElement). */
       private Hashtable tasks = new Hashtable();
       /** Mapping for when targets started (Task to TimedElement). */
  
  
  

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message