ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magesh Umasankar" <umag...@apache.org>
Subject Re: Patch Task enhancement
Date Wed, 20 Mar 2002 20:15:43 GMT
From: "Dominique Devienne" <DDevienne@lgc.com>

Hi Domnique:

> Hi Magesh,
>
> Given your comments on the provided Patch, and the long thread that's been
> going on the past few days about [PATCH] and [SUBMIT] messages being
> incomplete, I personally think that writing some kind of tutorial on how
to
> submit patch or new task would *greatly* improve the quality of the
> submissions. The checklist / guidelines you refer to helps some, but for
> most people (like me) who have programming skills, but no experience of
open
> source development, one or a few tutorials would be a tremendous boost.
This
> may actually improve the productivity of committers (for incorporating
> patches / submits) in the long run.
>
> Two tutorials that immediately come to mind are:
> * Adding one or more attribute to an existing task.
> * Adding a new task and/or data type.
>
> They would cover things like we're to modify the doc, how to generate it
to
> make sure it's correct (xdoc is not savadoc), how to generate the patch
set,
> etc...


Good idea! You seem to have a good idea of what you want
in the tutorial.  Please start writing one such
and submit it to ant-dev for review.  I will review
it as well and provide my comments.  Once we have
such a tutorial ready, I will commit it.

>
> Easier said than done of course, but from my view point, I'm not sure I'll
> ever venture into trying to submit of Patch to ANT after all I've read
> recently, having just the checklist to sort it out.

The checklist is not meant as a deterent.  You
may still submit the patches the way you like
with or without testcases, docs, etc.  It would
just take longer for it to be committed - that is
all.  We cannot obviously force anybody to provide a
complete patch set.


> As committers, you guys are obviously well organized
> bright people, and maybe forget that it can be
> hard to achieve your level of thoroughness.

I am not asking for patches to WHATSNEW, copyrights,
defaults.properties, etc. when one sends a patch set -
just good documentation patches and testcases - that is
thorough enough for me.


> I'm not asking to lower the standard of patch submissions,
> just helping the smocks like me out there
> raise to its challenges.

Help me help you by starting up on the
tutorial :-)

>
> Thanks, --DD
>

Cheers,
Magesh

***************************
*  Nil Magnum Nisi Bonum  *
***************************



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message