ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gert Driesen" <gert.drie...@pandora.be>
Subject Re: cvs commit: jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional JspcTest.java
Date Mon, 11 Mar 2002 19:09:59 GMT
I don't yet see how the current implementation of the JspC task will support
other jsp compilers :

- other compilers accept or even require other/more commandline options
- other compiler have other rules for mapping jsp files to java files (for
example, the weblogic jsp compiler will also convert the filename of the jsp
to lowercase, although it can be controlled by a option, and will insert '_'
at the start of the filename, so the jsp file 'SearchFile.jsp' will map to
'_searchfile.java')
- ....


----- Original Message -----
From: "Steve Loughran" <steve_l@iseran.com>
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Sent: Monday, March 11, 2002 7:24 PM
Subject: Re: cvs commit:
jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional
JspcTest.java


>
> ----- Original Message -----
> From: "Gert Driesen" <gert.driesen@pandora.be>
> To: "Ant Developers List" <ant-dev@jakarta.apache.org>
> Sent: Sunday, March 10, 2002 10:55 PM
> Subject: Re: cvs commit:
> jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs/optional
> JspcTest.java
>
>
> > Hi Steve,
> >
> > I seems that the scandir method in the Jspc class does not take the
> package
> > attribute into account.
>
> not yet no :)
>
> >
> > If a package was specified and the destDir/package (converted to path)
> > exists, the java file (if it was already generated before) would be
> located
> > in a package underneath the destDir path.
>
> it is more complicated than just this
>
> the task has to resolve all source directories relative to the uriroot and
> decide packages for all of them, *and* jasperc has to save stuff into that
> tree.
>
>
> >
> > So you should compare the last modified date of the java file in the
> > destDir/package location with the jsp file in de srcDir location.
>
> yup, but it will fall out of proper dir tree handling
>
> > I think you should also throw a BuildException if the source file that's
> > passed to the mapToJavaFile method isn't a jsp page.
>
> this I dont know about; we just ignore them, which is consistent with
> <javac>
>
>
>
>
>
>
>
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message