ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <jakarta-...@ehatchersolutions.com>
Subject Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/net TelnetTask.java
Date Tue, 19 Mar 2002 09:51:59 GMT
Doesn't this change break backwards compatibility?

As rare as it may be, what if someone was relying on writing out
${something} to the remote machine?

    Erik


----- Original Message -----
From: <stevel@apache.org>
To: <jakarta-ant-cvs@apache.org>
Sent: Tuesday, March 19, 2002 1:19 AM
Subject: cvs commit:
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/net
TelnetTask.java


> stevel      02/03/18 22:19:45
>
>   Modified:    src/main/org/apache/tools/ant/taskdefs/optional/net
>                         TelnetTask.java
>   Log:
>   set properties in nested strings. not tested.
>
>   Revision  Changes    Path
>   1.8       +10 -2
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/net/TelnetTask.j
ava
>
>   Index: TelnetTask.java
>   ===================================================================
>   RCS file:
/home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/net/Te
lnetTask.java,v
>   retrieving revision 1.7
>   retrieving revision 1.8
>   diff -u -r1.7 -r1.8
>   --- TelnetTask.java 8 Jan 2002 19:59:44 -0000 1.7
>   +++ TelnetTask.java 19 Mar 2002 06:19:45 -0000 1.8
>   @@ -70,7 +70,7 @@
>     * Class to provide automated telnet protocol support for the Ant build
tool
>     *
>     * @author <a
href="mailto:ScottCarlson@email.com">ScottCarlson@email.com</a>
>   - * @version $Revision: 1.7 $
>   + * @version $Revision: 1.8 $
>     */
>
>    public class TelnetTask extends Task {
>   @@ -246,7 +246,15 @@
>            {
>                throw new BuildException("Shouldn't be able instantiate a
SubTask directly");
>            }
>   -        public void addText(String s) { setString(s);}
>   +        /**
>   +         *  nested text elements need their properties explicitly
expanded
>   +         */
>   +        public void addText(String s) {
>   +            setString(project.replaceProperties(s));
>   +        }
>   +        /**
>   +         * attribute assignment of properties
>   +         */



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message