ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <jakarta-...@ehatchersolutions.com>
Subject Re: [Bug 7482] - PatternSet.setIncludes() does not SET includes, but appends them to a list
Date Wed, 27 Mar 2002 12:39:14 GMT
----- Original Message -----
From: "stephan beal" <stephan@wanderinghorse.net>
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Sent: Wednesday, March 27, 2002 5:30 AM
Subject: Re: [Bug 7482] - PatternSet.setIncludes() does not SET includes,
but appends them to a list


> On Tuesday 26 March 2002 22:11 pm, Erik Hatcher wrote:
> > I think you can
> > get PatternSet to do what you want, you just have to do it a different
way
> > - only call one of the methods and you get the 'set' functionality you
want
> > (again, encapsulate, don't extend in this case).
>
> i can refactor my class all day long, but in no case can i use the
> same PatternSet or FileSet twice (for two different, but mostly similar
> tasks, in which most properties are left the same on each run). This
cannot
> be done using those classes unless they provide, for example, a resetter
> method or a way to get a handle directly on their data members (which i
> generally don't condone, but it has it's place).

Like I just told you in private e-mail - what you are trying to do is
do-able without changes to Jar or PatternSet - you're just not seeing it.
We are all far too busy to code it up for you though, and to be honest, I'm
far too busy to even be replying to this thread as much as I have.  Have fun
hacking at it - but changes to PatternSet will likely be veto'd given the
unnecessary nature of such changes given your use-case.

> Jar extends Zip, which was probably also not designed to be extended - the
> only thing they share, AFAIK, is the actual compression format, and that
> could have been delegated into a ZipFile object (and would have been, i
> suspect, if you had designed it).

Two points that are being reiterated:

1) Not all of us were around when those task were written.
2) Subclassing is not a bad thing - you're just stuck in a rut thinking OO
is all about subclassing!  It ain't!

    Erik



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message