ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@cloud9.net>
Subject [PATCH] : ejbdeploy task (resubmit)
Date Wed, 27 Mar 2002 14:05:07 GMT
Ok, I made changes per Cyrille Morvan's suggestions.  Except, I still do
no think the Abstract class should do any Java invocation.  There is no
guarantee that the vendor-task will be written in Java.  While it's not
a big deal no override the Abstract deploy() method, several people have
already said they would rather not see Java specific stuff in the
abstract class.

Anyone care to chime in?

Erik.  Can you please commit these changes and ignore the previous
email?  Thank you.

- Chris

-----Original Message-----
From: cal@cloud9.net [mailto:cal@cloud9.net] 
Sent: Wednesday, March 27, 2002 8:32 AM
To: 'Ant Developers List'
Subject: RE: [PATCH] : ejbdeploy task


Ok, I will all the specific stuff down to the abstact class.  Let me up
some changes and see what you think.

> - The abstract class should provide a default deploy() implementation.
Using abstract method to construct the java task.



-----Original Message-----
Sure, it can't, because you can't use the same url to deploy on several 
servers.

So, I repeat, you should move server, username and password from
ServerDeploy to the Abstract class. Or duplicate the username and
password properties, 
in the two classes,
and implement a getUsername() and getPassword() in the Abstract class to
read local values before to read the ServerDeploy values.

<serverdeploy source="file" action="deploy">
    <weblogic username="cyrille" 
server="http://myserverONE:9898/weblogicconsole/" />
    <weblogic username="joe" 
server="http://myserverTWO:958/weblogicconsole/" />
    <jonas server="http://myserverThree:8080/jadmin/deploy.jws" />
</serverdeploy>

- Do you think it's a good :

<serverdeploy source="file" action="deploy">
    <weblogic username="cyrille" 
server="http://myserverOne:9898/weblogicconsole/" />
    <websphere username="joe" 
server="http://myserverTWO:958/weblogicconsole/" />
    <jonas server="http://myserverThree:8080/jadmin/deploy.jws" />
    <classpath>
         <include>/weblogic/lib/*.jar</include>
         <include>/websphere/lib/*.jar</include>
         <include>/jonas/lib/*.jar</include>
    </classpath>
</serverdeploy>

No because, we will have conflict with jndi.properties files and other
stuffs.

I prefer this :

<serverdeploy source="file" action="deploy">
    <weblogic username="cyrille" 
server="http://myserverOne:9898/weblogicconsole/" >
        <classpath>
         <include>/weblogic/lib/*.jar</include>
        </classpath>
    </weblogic>

    <websphere username="joe" 
server="http://myserverTwo:958/weblogicconsole/" >
        <classpath>
         <include>/websphere/lib/*.jar</include>
        </classpath>
    </websphere>

    <jonas server="http://myserverThree:8080/jadmin/deploy.jws" 
jonasroot="/jonas" />

   <classpath>
     <include>anything else</include>
   </classpath>

</serverdeploy>

- The abstract class should provide a default deploy() implementation.
Using abstract method to construct the java task.

- And at the end. The static values for the action, should no be in 
WebLogic class, but in the interface
or the abstract class ,because all the implementation need it.

Thanks.


--
To unsubscribe, e-mail: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail:
<mailto:ant-dev-help@jakarta.apache.org>


--
To unsubscribe, e-mail:
<mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail:
<mailto:ant-dev-help@jakarta.apache.org>

Mime
View raw message