Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 63951 invoked from network); 5 Feb 2002 23:32:14 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 5 Feb 2002 23:32:14 -0000 Received: (qmail 2332 invoked by uid 97); 5 Feb 2002 23:32:16 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 2293 invoked by uid 97); 5 Feb 2002 23:32:15 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 2282 invoked from network); 5 Feb 2002 23:32:15 -0000 From: "Conor MacNeill" To: "Ant Developers List" Subject: RE: cvs commit: jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs CopyTest.java Date: Wed, 6 Feb 2002 10:39:40 +1100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0) Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 In-Reply-To: <003d01c1ae9b$b27795b0$6401a8c0@darden.virginia.edu> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N If the ds basedir has already been resolved, you probably don't need to resolve it again so this approach may be more efficient. Conor > -----Original Message----- > From: Erik Hatcher [mailto:jakarta-ant@ehatchersolutions.com] > Sent: Wednesday, 6 February 2002 10:20 AM > To: Ant Developers List > Subject: Re: cvs commit: > jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs CopyTest.java > > > Nope, no reason.... I was just following along with the standard pattern > I've seen in other places for that particular patch. > > > ----- Original Message ----- > From: "Magesh Umasankar" > To: "Ant Developers List" > Sent: Tuesday, February 05, 2002 4:32 PM > Subject: cvs commit: > jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs > CopyTest.java > > > > > ehatcher 02/02/04 16:56:00 > > > > > > Modified: src/main/org/apache/tools/ant/taskdefs Copy.java > > > src/etc/testcases/taskdefs copy.xml > > > src/testcases/org/apache/tools/ant/taskdefs > CopyTest.java > > > > > > > if (srcFiles.length > 0) { > > > if (file == null) { > > > - file = new File(srcFiles[0]); > > > + file = new File(ds.getBasedir(), > srcFiles[0]); > > > filesets.removeElementAt(0); > > > } else { > > > throw new BuildException( > > > > Any specific reason why FileUtils.resolveFile is not > > being used instead of new File(...)? > > > > Cheers, > > Magesh > > > > **************************************************** > > * Atom Bomb: An invention to end all inventions. * > > **************************************************** > > > > > > -- > > To unsubscribe, e-mail: > > > For additional commands, e-mail: > > > > > > > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: > > -- To unsubscribe, e-mail: For additional commands, e-mail: