Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 97654 invoked from network); 20 Feb 2002 10:41:14 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 20 Feb 2002 10:41:14 -0000 Received: (qmail 23695 invoked by uid 97); 20 Feb 2002 10:41:20 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 23679 invoked by uid 97); 20 Feb 2002 10:41:20 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 23659 invoked from network); 20 Feb 2002 10:41:19 -0000 content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] /src/main/org/apache/tools/ant/IntrospectionHelper.java (More JavaDocs) X-MimeOLE: Produced By Microsoft Exchange V6.0.5762.3 Date: Wed, 20 Feb 2002 10:41:18 -0000 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] /src/main/org/apache/tools/ant/IntrospectionHelper.java (More JavaDocs) Thread-Index: AcG5+cLGRnK4xImfSRCTxnbE0bjRRQAARvqg From: "Jon Skeet" To: "Ant Developers List" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N > On Tue, 19 Feb 2002, Jon Skeet wrote: >=20 > > Requested clarification in constructor documentation and manual > > (addConfigured) >=20 > Yep, I'm sure it is burried somewhere done on Conor's list (and it is > on mine as well, which doesn't mean I want to do it 8-). >=20 > The difference between addConfiguredX and addX is that addConfiguredX > will hand out the Object after the setters on this Object have been > called while addX will be called before the child elements gets > configured. >=20 > > Why does storeElement return on null elementName / NestedStorer, > > where other methods will throw an exception? >=20 > In the case of elementName - I don't know. Conor, you should add an > author tag for yourself. >=20 > In the case of NestedStorer, this is because ProjectHelper will call > createElement before it calls storeElement, the excecption would have > been thrown their anyway. Furthermore ProjectHelper will call > storeElement even if the nested element was handled by createX or addX > methods that don't have NestedStorers associated to them. Ah - and that ties in with the earlier difference between addConfiguredX = and addX. I'm with you now :) =20 > > Commented on implementation of createAttributeSetter - can be made > > much simpler (although slightly slower). >=20 > I agree with your comments. I'll submit a separate patch for that then. =20 > > getElementName could be made static, which would add some clarity > > (IMO). >=20 > Not sure why it would add clarity, maybe it should be moved to the > Project class instead? Yes, it would be nicer in Project. Making it static would add clarity = (to me) as it would instantly indicate that it didn't depend on any of = the information contained within an instance of IntrospectionHelper. = Just my way of thinking though :) Jon -- To unsubscribe, e-mail: For additional commands, e-mail: