Return-Path: 
 <ant-dev-return-25628-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 95423 invoked from network); 18 Feb 2002 08:40:05 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 18 Feb 2002 08:40:05 -0000
Received: (qmail 6637 invoked by uid 97); 18 Feb 2002 08:40:14 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 6599 invoked by uid 97); 18 Feb 2002 08:40:13 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 6588 invoked by uid 97); 18 Feb 2002 08:40:13 -0000
Date: 18 Feb 2002 08:39:58 -0000
Message-ID: <20020218083958.95283.qmail@icarus.apache.org>
From: donaldp@apache.org
To: jakarta-ant-cvs@apache.org
Subject: cvs commit:
 jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/interfaces/service
 MultiSourceServiceManager.java
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

donaldp     02/02/18 00:39:58

  Modified:    proposal/myrmidon/src/java/org/apache/myrmidon/interfaces/service
                        MultiSourceServiceManager.java
  Log:
  Move complex operations outside loop body
  
  Revision  Changes    Path
  1.2       +7 -5      jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/interfaces/service/MultiSourceServiceManager.java
  
  Index: MultiSourceServiceManager.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/interfaces/service/MultiSourceServiceManager.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- MultiSourceServiceManager.java	14 Feb 2002 02:03:25 -0000	1.1
  +++ MultiSourceServiceManager.java	18 Feb 2002 08:39:58 -0000	1.2
  @@ -16,7 +16,7 @@
    * {@link ServiceManager} objects.
    *
    * @author <a href="mailto:adammurdoch@apache.org">Adam Murdoch</a>
  - * @version $Revision: 1.1 $ $Date: 2002/02/14 02:03:25 $
  + * @version $Revision: 1.2 $ $Date: 2002/02/18 08:39:58 $
    */
   public class MultiSourceServiceManager
       implements ServiceManager
  @@ -40,9 +40,10 @@
        *
        * @param serviceType The service interface.
        */
  -    public boolean hasService( Class serviceType )
  +    public boolean hasService( final Class serviceType )
       {
  -        for( int i = 0; i < m_sources.size(); i++ )
  +        final int size = m_sources.size();
  +        for( int i = 0; i < size; i++ )
           {
               final ServiceManager serviceManager = (ServiceManager)m_sources.get( i );
               if( serviceManager.hasService( serviceType ) )
  @@ -61,10 +62,11 @@
        *         implement the service interface.
        * @throws ServiceException If the service does not exist.
        */
  -    public Object getService( Class serviceType )
  +    public Object getService( final Class serviceType )
           throws ServiceException
       {
  -        for( int i = 0; i < m_sources.size(); i++ )
  +        final int size = m_sources.size();
  +        for( int i = 0; i < size; i++ )
           {
               final ServiceManager serviceManager = (ServiceManager)m_sources.get( i );
               if( serviceManager.hasService( serviceType ) )
  
  
  

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>