Return-Path: 
 <ant-dev-return-25623-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 93767 invoked from network); 18 Feb 2002 08:37:10 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 18 Feb 2002 08:37:10 -0000
Received: (qmail 3416 invoked by uid 97); 18 Feb 2002 08:37:16 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 3400 invoked by uid 97); 18 Feb 2002 08:37:16 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 3387 invoked by uid 97); 18 Feb 2002 08:37:15 -0000
Date: 18 Feb 2002 08:37:01 -0000
Message-ID: <20020218083701.94453.qmail@icarus.apache.org>
From: donaldp@apache.org
To: jakarta-ant-cvs@apache.org
Subject: cvs commit:
 jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/components/deployer
 Deployment.java
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

donaldp     02/02/18 00:37:00

  Modified:    proposal/myrmidon/src/java/org/apache/myrmidon/components/deployer
                        Deployment.java
  Log:
  Moved complex operations outside of loop evaluation
  
  Revision  Changes    Path
  1.21      +5 -3      jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/components/deployer/Deployment.java
  
  Index: Deployment.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/components/deployer/Deployment.java,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- Deployment.java	14 Feb 2002 02:07:02 -0000	1.20
  +++ Deployment.java	18 Feb 2002 08:37:00 -0000	1.21
  @@ -30,7 +30,7 @@
    *
    * @author <a href="mailto:peter@apache.org">Peter Donald</a>
    * @author <a href="mailto:adammurdoch@apache.org">Adam Murdoch</a>
  - * @version $Revision: 1.20 $ $Date: 2002/02/14 02:07:02 $
  + * @version $Revision: 1.21 $ $Date: 2002/02/18 08:37:00 $
    */
   class Deployment
       extends AbstractLogEnabled
  @@ -89,7 +89,8 @@
   
           // Deploy the roles
           // TODO - need to defer this
  -        for( int i = 0; i < roleDescriptors.size(); i++ )
  +        final int roleCount = roleDescriptors.size();
  +        for( int i = 0; i < roleCount; i++ )
           {
               final RoleDescriptor descriptor = (RoleDescriptor)roleDescriptors.get( i );
               deployRoles( descriptor );
  @@ -212,7 +213,8 @@
           throws Exception
       {
           final ArrayList descriptors = new ArrayList();
  -        for( int i = 0; i < urls.size(); i++ )
  +        final int size = urls.size();
  +        for( int i = 0; i < size; i++ )
           {
               final String url = (String)urls.get( i );
   
  
  
  

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>