Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 98112 invoked from network); 3 Feb 2002 11:47:21 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 3 Feb 2002 11:47:21 -0000 Received: (qmail 7547 invoked by uid 97); 3 Feb 2002 11:47:18 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 7531 invoked by uid 97); 3 Feb 2002 11:47:18 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 7520 invoked from network); 3 Feb 2002 11:47:18 -0000 Message-Id: <200202031147.g13BlGR01686@mail004.syd.optusnet.com.au> Content-Type: text/plain; charset="utf-8" From: Peter Donald To: "Ant Developers List" Subject: Re: cvs commit: jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/api AbstractTask.java Date: Sun, 3 Feb 2002 22:43:34 +1100 X-Mailer: KMail [version 1.3.2] References: <20020203102944.56267.qmail@icarus.apache.org> <002701c1aca4$c29b0d80$6401a8c0@darden.virginia.edu> In-Reply-To: <002701c1aca4$c29b0d80$6401a8c0@darden.virginia.edu> X-Wisdom-Cookie: . MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sun, 3 Feb 2002 22:20, Erik Hatcher wrote: > I would encourage us to use the "@todo" tag for such notes - XDoclet > contains a great subtask that will generate a Javadoc-like frames > HTML report of all such tags. sounds like a plan. This is something we could do in the ant1.x codebase aswell. Now I just have to get out of the habit of using the HACK/FIXME etc comments ;) > > > ----- Original Message ----- > From: > To: > Sent: Sunday, February 03, 2002 5:29 AM > Subject: cvs commit: > jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/api > AbstractTask.java > > > donaldp 02/02/03 02:29:44 > > > > Modified: proposal/myrmidon/src/java/org/apache/myrmidon/api > > AbstractTask.java > > Log: > > Make accessor method public (UGLY HACK WARNING!) for time being until > > tasks are more fully migrated > > > Revision Changes Path > > 1.17 +2 -1 > > jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/api/AbstractTask >. java > > > Index: AbstractTask.java > > =================================================================== > > RCS file: > > /home/cvs/jakarta-ant/proposal/myrmidon/src/java/org/apache/myrmidon/api/Ab >s tractTask.java,v > > > retrieving revision 1.16 > > retrieving revision 1.17 > > diff -u -r1.16 -r1.17 > > --- AbstractTask.java 3 Feb 2002 03:51:23 -0000 1.16 > > +++ AbstractTask.java 3 Feb 2002 10:29:44 -0000 1.17 > > @@ -84,7 +84,8 @@ > > return getContext().getProperty( name ); > > } > > > > - protected final Object getService( final Class serviceClass ) > > + ///HACK: Make this protected > > + public final Object getService( final Class serviceClass ) > > throws TaskException > > { > > return getContext().getService( serviceClass ); > > > > > > > > > > -- > > To unsubscribe, e-mail: > > For additional commands, e-mail: -- Cheers, Pete ------------------------------------------------------- "I would like to take you seriously but to do so would affront your intelligence" -William F. Buckley, JR ------------------------------------------------------- -- To unsubscribe, e-mail: For additional commands, e-mail: