Return-Path: 
 <ant-dev-return-24209-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 91019 invoked from network); 1 Feb 2002 15:31:32 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 1 Feb 2002 15:31:32 -0000
Received: (qmail 28052 invoked by uid 97); 1 Feb 2002 15:31:25 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 28020 invoked by uid 97); 1 Feb 2002 15:31:25 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 28006 invoked by uid 50); 1 Feb 2002 15:31:24 -0000
Date: 1 Feb 2002 15:31:24 -0000
Message-ID: <20020201153124.28005.qmail@nagoya.betaversion.org>
From: bugzilla@apache.org
To: ant-dev@jakarta.apache.org
Cc: 
Subject: DO NOT REPLY [Bug 6180] New:  -
    [PATCH] Package Version Identification in ant.jar manifest file
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6180

[PATCH] Package Version Identification in ant.jar manifest file

           Summary: [PATCH] Package Version Identification in ant.jar
                    manifest file
           Product: Ant
           Version: 1.5 alpha (nightly)
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Build Process
        AssignedTo: ant-dev@jakarta.apache.org
        ReportedBy: hboutemy@business-village.fr


Here is a patch to include Ant's version in the manifest file.

This way, determining the version of ant.jar is *standard* (and easy).
PVI specification is available since jdk 1.2, it's very helpfull, but it is 
quite unused...
see http://java.sun.com/products/jdk/1.2/docs/guide/versioning/index.html

Remark : I'm not sure if the value of Implementation-Version as the build-date 
is really a good choice...

Index: build.xml
===================================================================
RCS file: /home/cvspublic/jakarta-ant/build.xml,v
retrieving revision 1.233
diff -u -r1.233 build.xml
--- build.xml	1 Feb 2002 07:34:33 -0000	1.233
+++ build.xml	1 Feb 2002 15:28:53 -0000
@@ -343,6 +343,12 @@
       <filterset refid="ant.filters"/>
     </copy>
 
+    <copy    file="${manifest}"
+             toFile="${build.classes}/manifest"
+             overwrite="true">
+      <filterset refid="ant.filters"/>
+    </copy>
+
     <copy todir="${build.classes}/${optional.package}/junit/xsl">
        <fileset dir="${etc.dir}">
          <include name="junit-frames.xsl" />
@@ -365,7 +371,8 @@
     
     <jar destfile="${build.lib}/${name}.jar"
          basedir="${build.classes}"
-         manifest="${manifest}">
+         manifest="${build.classes}/manifest">
+      <exclude name="manifest" />
       <exclude name="org/apache/tools/ant/taskdefs/optional/**" />
       <metainf dir="${build.dir}" includes="LICENSE.txt"/>
     </jar>


Index: manifest
===================================================================
RCS file: /home/cvspublic/jakarta-ant/src/etc/manifest,v
retrieving revision 1.3
diff -u -r1.3 manifest
--- manifest	1 Aug 2001 21:37:50 -0000	1.3
+++ manifest	1 Feb 2002 15:07:34 -0000
@@ -2,4 +2,10 @@
 Main-Class: org.apache.tools.ant.Main
 Class-Path: jaxp.jar parser.jar crimson.jar optional.jar xalan.jar
 
-
+Name: org/apache/tools/ant
+Specification-Title: Apache Ant
+Specification-Vendor: Apache Jakarta (http://jakarta.apache.org/)
+Specification-Version: @VERSION@
+Implementation-Title: org.apache.tools.ant
+Implementation-Vendor: Apache Jakarta (http://jakarta.apache.org/)
+Implementation-Version: @DATE@

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>