One reason would be that srcfiles[0] is known to be relative to the
fileset's base dir, and is already normalised. No real point passing it off
to resolveFile() so that it can return exactly the same value.
> -----Original Message-----
> From: Erik Hatcher [mailto:jakarta-ant@ehatchersolutions.com]
> Sent: Wednesday, 6 February 2002 9:20 AM
> To: Ant Developers List
> Subject: Re: cvs commit:
> jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs CopyTest.java
>
>
> Nope, no reason.... I was just following along with the standard pattern
> I've seen in other places for that particular patch.
>
>
> ----- Original Message -----
> From: "Magesh Umasankar" <umagesh@apache.org>
> To: "Ant Developers List" <ant-dev@jakarta.apache.org>
> Sent: Tuesday, February 05, 2002 4:32 PM
> Subject: cvs commit:
> jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs
> CopyTest.java
>
>
> > > ehatcher 02/02/04 16:56:00
> > >
> > > Modified: src/main/org/apache/tools/ant/taskdefs Copy.java
> > > src/etc/testcases/taskdefs copy.xml
> > > src/testcases/org/apache/tools/ant/taskdefs
> CopyTest.java
> >
> >
> > > if (srcFiles.length > 0) {
> > > if (file == null) {
> > > - file = new File(srcFiles[0]);
> > > + file = new File(ds.getBasedir(),
> srcFiles[0]);
> > > filesets.removeElementAt(0);
> > > } else {
> > > throw new BuildException(
> >
> > Any specific reason why FileUtils.resolveFile is not
> > being used instead of new File(...)?
> >
> > Cheers,
> > Magesh
> >
> > ****************************************************
> > * Atom Bomb: An invention to end all inventions. *
> > ****************************************************
> >
> >
> > --
> > To unsubscribe, e-mail:
<mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
--
To unsubscribe, e-mail: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
|