ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Skeet" <jon.sk...@peramon.com>
Subject [PATCH] src/main/org.apache.tools.ant.AntClassLoader
Date Wed, 13 Feb 2002 14:48:38 GMT
This is the first patch generated as per the thread entitled "Apologies
and different offer of help..." As such it's a sort of sample patch.
There is one small code change (which may very briefly reduce the
footprint of Ant by about 3K :) and two comments which suggests further
code changes (look for XXX). The rest is, I believe, entirely comments.
I've:

o Made sure that all occurences of null/true/false are surrounded by
<code></code>
o Wrapped comments to under 80 columns (in some ways this is more
important than wrapping code)
o Made sure that all fields and methods have JavaDoc documentation.
o All used method parameters are documented, including documentation of
whether they can be null or not
o All return types are documented
o All checked exceptions are documented

Stylistic comments (etc) very welcome before I do the "wrong" thing to
do many files :)

Jon

Mime
View raw message