ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Burton" <bi...@progress.com>
Subject Re: [PATCH] /src/main/org/apache/tools/ant/IntrospectionHelper.java (More JavaDocs)
Date Tue, 19 Feb 2002 18:26:05 GMT
Hello,

Saw a couple of minor issues with this patch.
1. In many places is this: (String->Class).
   It would be better as: (String-&gt;Class).

2. In at least a couple of places you've added // comments after the
javadoc comment but before a method, i.e. IntrospectionHelper and
createAttributeSetter.  Unless something's changed in a recent version of
javadoc, the // comments will prevent javadoc from associating the javadoc
comment with the method, etc. below it.  Have you checked to make sure
javadoc is being generated for these methods?

Otherwise, nice job.  

-Bill

Jon Skeet wrote:
> 
> Just the one class today, 'cos it was a biggie :)
> 
> Notes:
> 
> Requested clarification in constructor documentation and manual
> (addConfigured)
> 
> Changed a couple of parameter names for clarity (element->parent in both
> cases, IIRC).
> 
> Why does storeElement return on null elementName / NestedStorer,
> where other methods will throw an exception?
> 
> Commented on implementation of createAttributeSetter - can be made
> much simpler (although slightly slower).
> 
> getElementName could be made static, which would add some clarity
> (IMO).
> 
> The various one-method interfaces haven't been documented in detail, as
> they
> ended up reducing code readability.
> 
> Jon

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message